fix(ci): set only one Tauri signing key source for signer - #9
Merged
Conversation
tauri signer sign fails when both TAURI_SIGNING_PRIVATE_KEY and TAURI_SIGNING_PRIVATE_KEY_PATH are set. Prefer the key body, unset the path, and reuse the archive+sig already produced by tauri build when present. Co-authored-by: Joshua Kifer <joshua@moonlight.pm> Signed-off-by: Joshua Kifer <joshua@moonlight.pm>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Canary #4: full app+DMG build succeeded; failed only on
tauri signer signbecause bothTAURI_SIGNING_PRIVATE_KEYand_PATHwere set. Unset path after loading body.