-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Rust version to 1.81.0 #691
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanocryk
added
a0-pleasereview
Pull request needs code review.
B0-silent
Changes should not be mentioned in any release notes
D3-trivial
PR contains trivial changes in a runtime directory that do not require an audit
labels
Sep 25, 2024
tmpolaczyk
reviewed
Sep 27, 2024
tmpolaczyk
reviewed
Sep 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, merge back master please
nanocryk
force-pushed
the
jeremy-bump-rust-version
branch
from
October 2, 2024 09:45
c6279b0
to
0c457c3
Compare
tmpolaczyk
approved these changes
Oct 4, 2024
We seem to hit the same issue as described in this Rust issue, which seems to be a compiler regression. Until it is fixed, we can make progress by adding |
girazoki
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
a0-pleasereview
Pull request needs code review.
B0-silent
Changes should not be mentioned in any release notes
D3-trivial
PR contains trivial changes in a runtime directory that do not require an audit
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using same version as paritytech/polkadot-sdk#5676
We're currently on 1.78.0, and I'd like to use this feature introduced in 1.79.0, which will allow to shorten a lot our
where
-clauses with trait aliases that can imply/infer associated types bounds.