Conversation
girazoki
commented
Aug 23, 2023
|
|
||
| parameter_types! { | ||
| pub DefaultBaseFeePerGas: U256 = U256::from(1_000_000_000); | ||
| pub DefaultBaseFeePerGas: U256 = U256::from(2_000_000_000); |
Contributor
Author
There was a problem hiding this comment.
This internal gets multiplied by the ideal target fullness (50%) to calculate the minimum gas price below which we cannot drop
Contributor
Author
There was a problem hiding this comment.
In short, at most the minimum gas price can drop to 1gWei
tmpolaczyk
reviewed
Aug 23, 2023
Contributor
|
Master coverage: 65.21% |
tmpolaczyk
approved these changes
Aug 24, 2023
girazoki
added a commit
that referenced
this pull request
Aug 24, 2023
* Fix ethereum gas pricing * update comment * fmt * increment spec versions
rimbi
pushed a commit
to rimbi/tanssi
that referenced
this pull request
Oct 17, 2023
* Fix ethereum gas pricing * update comment * fmt * increment spec versions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings polkadot-evm/frontier#1115 and sets the correct value in the max block gas and miliseconds per block, so that gas calculation is correct with respect to weight