Skip to content

Conversation

@dimartiro
Copy link
Contributor

@dimartiro dimartiro commented May 29, 2025

Description

Update polkadot-sdk, frontier, dancekit and moonkit dependencies to stable2503

Main changes

Elastic Scaling

Cumulus

  • cumulus-primitives-storage-weight-reclaim replaced by cumulus-pallet-weight-reclaim since it was deprecated
    • cumulus_pallet_weight_reclaim::Config added for Runtime

Snowbridge

Changes due snowbridge V2 - PR

  • snowbridge-outbound-queue-merkle-tree moved to snowbridge-merkle-tree
  • create_agent, transfer_native_from_agent, create_channel and update_channel were removed

Pallet Balances

RPC

  • EthDeps::graph and FullDeps::graph type modified from Arc<Pool<A>> to Arc<P> since it was modified in frontier

Misc

  • parity_scale_codec::DecodeWithMemTracking implemented for some types
  • BlockNumberProvider added as config for some pallets, always using frame_system
  • New configs were added for some pallets so I added some TODOS to review them properly during this PR review
  • bounded-collections is imported from my fork while waiting for parity to approve the PR

TODO

  • Solve pending TODOs in the code
  • Fix benchmarks
  • Fix rust tests
    • fix Container chain author data needs to be present in every block! errors
    • fix Orchestrator chain authorities data needs to be present in every block! errors
  • Replace parity-commons dimartiro's fork to upstream when this PR is merged
    • Pull polkadot-sdk changes to our fork when they merge this PR
  • Fix build
  • Fix clippy
  • Pallet migrations
  • Debug and fix chopstick tests failing due timeouts
    • Note: chopstick tests are passing locally so it must be related with a CI issue
  • Fix ts tests

@dimartiro dimartiro self-assigned this May 29, 2025
@github-actions
Copy link
Contributor

github-actions bot commented May 29, 2025

WASM runtime size check:

Compared to target branch

dancebox runtime: 1680 KB (+180 KB) ⚠️

flashbox runtime: 1040 KB (+156 KB) ⚠️

dancelight runtime: 2460 KB (+56 KB) 🚨

starlight runtime: 2380 KB (+72 KB) ⚠️

container chain template simple runtime: 1336 KB (+172 KB) ⚠️

container chain template frontier runtime: 1640 KB (+196 KB) ⚠️

@dimartiro dimartiro added breaking Needs to be mentioned in breaking changes A3-inprogress Pull request is in progress. No review needed at this stage. B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited labels Jun 3, 2025
@dimartiro dimartiro force-pushed the update-stable2503 branch from 1f74995 to f7cdd1c Compare June 6, 2025 00:26
@dimartiro dimartiro marked this pull request as ready for review July 6, 2025 23:32
@girazoki girazoki enabled auto-merge (squash) July 8, 2025 08:17
@girazoki girazoki merged commit 52add3f into master Jul 8, 2025
106 of 108 checks passed
@girazoki girazoki deleted the update-stable2503 branch July 8, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A3-inprogress Pull request is in progress. No review needed at this stage. A8-mergeoncegreen Pull request is reviewed well. B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants