Closed
Conversation
notlesh
added
A0-pleasereview
crystalin
approved these changes
Sep 14, 2021
Collaborator
crystalin
left a comment
crystalin
left a comment
There was a problem hiding this comment.
@JoshOrndorff if you can review it too
Collaborator
|
Should we expect any of the typescript test to fail with this change? Might well be the case right? |
Contributor
|
The code does as it says on the tin. Is there some justification for this number though? Like what's the weight of some simple extrinsics, and the corresponding fee? What about: balances::transfer |
Contributor
Author
|
I'm closing this out for now until we have a more thorough understanding of the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do?
Adds
WeightToFeemultiplier of1 MWei. This is extracted from #730 .