Skip to content

Add smoke tests for eth_subscribe#3565

Merged
RomarQ merged 6 commits intomasterfrom
manuel/add-new-smoke-tests-for-eth-subscribe
Dec 5, 2025
Merged

Add smoke tests for eth_subscribe#3565
RomarQ merged 6 commits intomasterfrom
manuel/add-new-smoke-tests-for-eth-subscribe

Conversation

@manuelmauro
Copy link
Copy Markdown
Contributor

@manuelmauro manuelmauro commented Dec 2, 2025 •
edited
Loading

What does it do?

Adds a new cherry-pick on frontier (moonbeam-foundation/frontier@4a59cee) and new smoke tests for eth_subscribe.

@manuelmauro manuelmauro self-assigned this Dec 2, 2025
@manuelmauro manuelmauro added B0-silent Changes should not be mentioned in any release notes D2-notlive PR doesn't change runtime code (so can't be audited) not-breaking Does not need to be mentioned in breaking changes labels Dec 2, 2025
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Dec 2, 2025

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • agent-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch manuel/add-new-smoke-tests-for-eth-subscribe

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 2, 2025 •
edited
Loading

WASM runtime size check:

Compared to target branch

Moonbase runtime: 2112 KB (no changes) ✅

Moonbeam runtime: 2240 KB (no changes) ✅

Moonriver runtime: 2240 KB (no changes) ✅

Compared to latest release (runtime-4001)

Moonbase runtime: 2112 KB (+340 KB compared to latest release) ⚠️

Moonbeam runtime: 2240 KB (+376 KB compared to latest release) ⚠️

Moonriver runtime: 2240 KB (+376 KB compared to latest release) ⚠️

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 2, 2025 •
edited
Loading

Coverage Report

@@                               Coverage Diff                               @@
##           master   manuel/add-new-smoke-tests-for-eth-subscribe     +/-   ##
===============================================================================
  Coverage   76.75%                                         76.75%   0.00%     
  Files         388                                            388             
  Lines       76182                                          76182             
===============================================================================
  Hits        58471                                          58471             
  Misses      17711                                          17711
Files Changed Coverage

Coverage generated Fri Dec 5 10:13:20 UTC 2025

@manuelmauro manuelmauro marked this pull request as ready for review December 3, 2025 10:41
@manuelmauro manuelmauro mentioned this pull request Dec 3, 2025
Closed
@manuelmauro
Copy link
Copy Markdown
Contributor Author

manuelmauro commented Dec 3, 2025

Merge only after this PR is approved: polkadot-evm/frontier#1781

RomarQ
RomarQ reviewed Dec 4, 2025
View reviewed changes
Comment thread test/suites/smoke/test-eth-subscribe-newheads.ts Outdated
RomarQ
RomarQ reviewed Dec 4, 2025
View reviewed changes
Comment thread test/suites/smoke/test-eth-subscribe-newheads.ts Outdated
@RomarQ RomarQ added the A8-mergeoncegreen Pull request is reviewed well. label Dec 5, 2025
@RomarQ RomarQ merged commit cbc92dc into master Dec 5, 2025
43 checks passed
@RomarQ RomarQ deleted the manuel/add-new-smoke-tests-for-eth-subscribe branch December 5, 2025 10:19
manuelmauro added a commit that referenced this pull request Dec 15, 2025
@manuelmauro
Revert "Add smoke tests for eth_subscribe (#3565)"
ada676d 
This reverts commit cbc92dc.
RomarQ pushed a commit that referenced this pull request Dec 15, 2025
@manuelmauro
Revert "Add smoke tests for eth_subscribe (#3565)" (#3591)
b58fb23 
This reverts commit cbc92dc.
manuelmauro added a commit that referenced this pull request Dec 16, 2025
@manuelmauro @RomarQ
Add smoke tests for eth_subscribe (#3565)
d075166 
* test: ✅ add smoke tests for eth_subscribe

* test: ✅ update test expectations

* chore: 📌 update pin

* revert: 🔥 remove redundant test

* refactor: ♻️ merge newHeads smoke tests into a single one

---------

Co-authored-by: Rodrigo Quelhas <22591718+RomarQ@users.noreply.github.com>
RomarQ added a commit that referenced this pull request Dec 17, 2025
@RomarQ
Revert "Add smoke tests for eth_subscribe (#3565)"
382fd85 
This reverts commit cbc92dc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RomarQ RomarQ RomarQ approved these changes

Assignees

@manuelmauro manuelmauro

Labels

A8-mergeoncegreen Pull request is reviewed well. B0-silent Changes should not be mentioned in any release notes D2-notlive PR doesn't change runtime code (so can't be audited) not-breaking Does not need to be mentioned in breaking changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@manuelmauro @RomarQ