Made a test for reading block gas limit in contracts

[joelamouche]

What does it do?

• deploys

pragma solidity >=0.8.0;

// Docs I'm following to get these properties
// https://docs.soliditylang.org/en/v0.8.2/units-and-global-variables.html

contract CheckBlockGasLimit {
    // This one is broken (evaluates to 0)
    uint public gas;
    // This one works
    uint public chainid;
    
    constructor() {
      gas = block.gaslimit;
      chainid = block.chainid;
   }
}

• calls gas variable and check that it is>0
• uses solc package to compile solidity into bytecode and abi

What important points reviewers should know?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

polkadot-evm/frontier#327
polkadot-evm/frontier#332

Checklist

• ❌ Does it require a purge of the network?
• You bumped the runtime version if there are breaking changes in the runtime ?
• ❌ Does it require changes in documentation/tutorials ?

[JoshOrndorff]

The test looks good. Thanks @joelamouche Mind if I take over this PR and merge it once I get the test passing?

[JoshOrndorff]

Yeah, this is awesome! We should do all of our solidity-based tests this way.

[joelamouche]

So at first I thought to myself that the repo would be cleaner if we did this for every single contract but then I thought that recompiling every contract every test might slightly increase the duration of testing. Thoughts @crystalin @JoshOrndorff ?

[crystalin]

We should have a smart contract factory, that compiles (and kind of cache) on demand

…

On Thu, Apr 8, 2021, 11:03 AM Antoine Estienne ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In tests/tests/constants/testContracts.ts <#337 (comment)>: > @@ -1,4 +1,33 @@ import { AbiItem } from "web3-utils"; +import solc from "solc"; + +export function compileSolidity(contractContent: string, contractName: string = "Test") { So at first I thought to myself that the repo would be cleaner if we did this for every single contract but then I thought that recompiling every contract every test might slightly increase the duration of testing. Thoughts @crystalin <https://github.com/crystalin> @JoshOrndorff <https://github.com/JoshOrndorff> ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#337 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACQMIATEUMX2VN3BYABVXLTHXAVBANCNFSM42SXABCA> .

[joelamouche]

What do you mean by "kind of cache" ?

[crystalin]

I meant that if you request the same contract in another test it serves the bytecode right away without recompiling it

…

On Thu, Apr 8, 2021, 12:42 PM Antoine Estienne ***@***.***> wrote: What do you mean by "kind of cache" ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#337 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACQMIHFMG7FB5YJKNRXGPLTHXMHJANCNFSM42SXABCA> .

[crystalin]

Closing it in favor of #370