Add block range validation to eth_getLogs RPC#3250
Merged
Conversation
Contributor
WASM runtime size check:Compared to target branchMoonbase runtime: 2424 KB (no changes) 🚨 Moonbeam runtime: 2408 KB (no changes) 🚨 Moonriver runtime: 2396 KB (no changes) ✅ Compared to latest release (runtime-3600)Moonbase runtime: 2424 KB (+468 KB compared to latest release) 🚨 Moonbeam runtime: 2408 KB (+464 KB compared to latest release) 🚨 Moonriver runtime: 2396 KB (+456 KB compared to latest release) |
Contributor
Coverage Report@@ Coverage Diff @@
## master rq/add-block-range-limit +/- ##
===========================================================
Coverage 74.20% 74.20% 0.00%
Files 383 383
+ Lines 97217 97225 +8
===========================================================
+ Hits 72134 72139 +5
+ Misses 25083 25086 +3
|
RomarQ
added
the
B5-clientnoteworthy
RomarQ
added
breaking
stiiifff
approved these changes
Apr 16, 2025
RomarQ
added a commit
that referenced
this pull request
Apr 23, 2025
* add basic test * add max block range * validate error in test --------- Co-authored-by: snowmead <michael.assaf.edge@gmail.com> Co-authored-by: Michael Assaf <94772640+snowmead@users.noreply.github.com>
RomarQ
added a commit
that referenced
this pull request
Apr 23, 2025
* Add block range validation to eth_getLogs RPC (#3250) * add basic test * add max block range * validate error in test --------- Co-authored-by: snowmead <michael.assaf.edge@gmail.com> Co-authored-by: Michael Assaf <94772640+snowmead@users.noreply.github.com> * fix CI * fix CI --------- Co-authored-by: snowmead <michael.assaf.edge@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on Frontier - moonbeam-foundation/frontier#245
Adds a cli parameter named
--max-block-range <RANGE>for customising the block range limit when queryingeth_getLogsRPC, the default value is1024blocks. Trying to queryeth_getLogsfor a block range higher than1024will result in the following error message:block range is too wide (maximum 1024).