Skip to content

enable MBIP-5 on Moonriver #2500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahmadkaouk merged 3 commits into from
Oct 6, 2023
Merged

enable MBIP-5 on Moonriver #2500

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dbc6f66
enable MBIP-5 on Moonriver
ahmadkaouk Sep 22, 2023
8d4b499
add rust test to check if constant matchs the formula
ahmadkaouk Oct 4, 2023
c277a84
add some comments
ahmadkaouk Oct 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions runtime/moonriver/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,8 +406,9 @@ parameter_types! {
/// (max_extrinsic.ref_time() / max_extrinsic.proof_size()) / WEIGHT_PER_GAS
/// )
pub const GasLimitPovSizeRatio: u64 = 4;
/// The amount of gas per storage (in bytes).
pub GasLimitStorageGrowthRatio: u64 = 0;
/// The amount of gas per storage (in bytes): BLOCK_GAS_LIMIT / BLOCK_STORAGE_LIMIT
/// The current definition of BLOCK_STORAGE_LIMIT is 40 KB, resulting in a value of 366.
pub GasLimitStorageGrowthRatio: u64 = 366;
Comment thread
ahmadkaouk marked this conversation as resolved.
}

pub struct TransactionPaymentAsGasPrice;
Expand Down Expand Up @@ -1760,4 +1761,19 @@ mod tests {
.base_extrinsic;
assert!(base_extrinsic.ref_time() <= min_ethereum_transaction_weight.ref_time());
}

#[test]
fn test_storage_growth_ratio_is_correct() {
// This is the highest amount of new storage that can be created in a block 40 KB
let block_storage_limit = 40 * 1024;
let expected_storage_growth_ratio = BlockGasLimit::get()
.low_u64()
.saturating_div(block_storage_limit);
let actual_storage_growth_ratio =
<Runtime as pallet_evm::Config>::GasLimitStorageGrowthRatio::get();
assert_eq!(
expected_storage_growth_ratio, actual_storage_growth_ratio,
"Storage growth ratio is not correct"
);
}
}