Skip to content

Clean up min multiplier#2070

Merged
notlesh merged 4 commits intomasterfrom
notlesh-clean-up-min-multiplier
Feb 3, 2023
Merged

Clean up min multiplier#2070
notlesh merged 4 commits intomasterfrom
notlesh-clean-up-min-multiplier

Conversation

@notlesh
Copy link
Contributor

@notlesh notlesh commented Feb 1, 2023 •
edited
Loading

What does it do?

Cleans up the MinimumMultiplier used for our pallet-transaction-payment config.

Specifically:

Additionally, TODO:

  • Add tests to show what this does in terms of base_fee

@notlesh notlesh added B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit breaking Needs to be mentioned in breaking changes and removed B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes labels Feb 1, 2023
timbrinded
timbrinded approved these changes Feb 3, 2023
View reviewed changes
Copy link
Contributor

@timbrinded timbrinded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@notlesh notlesh merged commit 3c0e477 into master Feb 3, 2023
@notlesh notlesh deleted the notlesh-clean-up-min-multiplier branch February 3, 2023 18:11
imstar15 pushed a commit to AvaProtocol/moonbeam that referenced this pull request May 16, 2023
@notlesh @imstar15
Clean up min multiplier (moonbeam-foundation#2070)
b363054 
* Bump moonbase MinimumMultiplier

* Fix endianness; add min multiplier tests

* Add gasPrice expects

* prettier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timbrinded timbrinded timbrinded approved these changes

Assignees

No one assigned

Labels

B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@notlesh @timbrinded