Skip to content

Derive TypeInfo for EthereumSigner#1969

Merged
nanocryk merged 2 commits into
moonbeam-foundation:masterfrom
jiguantong:patch-1
Dec 8, 2022
Merged

Derive TypeInfo for EthereumSigner#1969
nanocryk merged 2 commits into
moonbeam-foundation:masterfrom
jiguantong:patch-1

Conversation

@jiguantong
Copy link
Copy Markdown
Contributor

What does it do?

Derive TypeInfo for EthereumSigner

What important points reviewers should know?

no

Is there something left for follow-up PRs?

no

What alternative implementations were considered?

no

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

no

What value does it bring to the blockchain users?

@nanocryk nanocryk added A0-pleasereview Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low Does not elevate a release containing this beyond "low priority". D3-trivial PR contains trivial changes in a runtime directory that do not require an audit labels Nov 29, 2022
@nanocryk
Copy link
Copy Markdown
Contributor

Please run cargo fmt.

@nanocryk nanocryk merged commit 53dad79 into moonbeam-foundation:master Dec 8, 2022
@jiguantong jiguantong deleted the patch-1 branch December 8, 2022 13:27
@jiguantong jiguantong restored the patch-1 branch December 8, 2022 13:27
imstar15 pushed a commit to AvaProtocol/moonbeam that referenced this pull request May 16, 2023
* Derive `TypeInfo` for `EthereumSigner`

* format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A0-pleasereview Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low Does not elevate a release containing this beyond "low priority". D3-trivial PR contains trivial changes in a runtime directory that do not require an audit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants