Skip to content

Frontier db v2 migration#1862

Merged
tgmichel merged 4 commits intomasterfrom
tgm-frontier-db-v2-migration
Oct 14, 2022
Merged

Frontier db v2 migration#1862
tgmichel merged 4 commits intomasterfrom
tgm-frontier-db-v2-migration

Conversation

@tgmichel
Copy link
Copy Markdown
Contributor

@tgmichel tgmichel commented Oct 11, 2022 •
edited
Loading

What does it do?

Details in polkadot-evm/frontier#862

  • This migration moves to a new schema that supports equivocation in the Frontier offchain DB and it also replaces eventual orphan block hashes found for its canonical counterparts.
  • Migration time will be heavily affected by db-cache cli arg, obviously the more the better.
  • A more detailed migration progress can be enabled including -lfc-db-upgrade=debug.
  • If the process is closed before finishing the migration it will resume when starting the process again, but is highly recommended to not kill the process.

What important points reviewers should know?

parity-db is not compatible with the migration, there is no clear Api to achieve it. Nodes using parity-db will need to re-sync.

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

@tgmichel tgmichel added A0-pleasereview Pull request needs code review. B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit labels Oct 11, 2022
@tgmichel tgmichel marked this pull request as ready for review October 13, 2022 12:14
crystalin
crystalin reviewed Oct 13, 2022
View reviewed changes
@librelois librelois mentioned this pull request Oct 13, 2022
Closed
12 tasks
@tgmichel tgmichel requested a review from crystalin October 14, 2022 12:42
@tgmichel tgmichel merged commit 8cb5c08 into master Oct 14, 2022
@tgmichel tgmichel deleted the tgm-frontier-db-v2-migration branch October 14, 2022 12:54
@crystalin crystalin mentioned this pull request Oct 14, 2022
Closed
imstar15 pushed a commit to AvaProtocol/moonbeam that referenced this pull request May 16, 2023
@tgmichel @timbrinded @imstar15
Frontier db v2 migration (moonbeam-foundation#1862)
6833330 
* Frontier db v2 migration

* Fixed para-test

* fixed console msg

* Better wait

Co-authored-by: timbrinded <timbrinded@gmail.com>
Co-authored-by: Crystalin <alan@purestake.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crystalin crystalin crystalin approved these changes

@librelois librelois Awaiting requested review from librelois

Assignees

No one assigned

Labels

A0-pleasereview Pull request needs code review. B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tgmichel @crystalin @timbrinded