Base XCM weight increase#1791
Merged
Merged
Conversation
girazoki
added
A0-pleasereview
tgmichel
approved these changes
Aug 30, 2022
Contributor
tgmichel
left a comment
tgmichel
left a comment
There was a problem hiding this comment.
Lgtm, aligns well with the current rocksdb weight costs and the expected reads and writes for xcm common operations.
nanocryk
approved these changes
Aug 30, 2022
notlesh
approved these changes
Aug 30, 2022
jiguantong
added a commit
to darwinia-network/darwinia-parachain
that referenced
this pull request
Sep 8, 2022
jiguantong
added a commit
to darwinia-network/darwinia-parachain
that referenced
this pull request
Oct 12, 2022
notlesh
added
D1-audited👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do?
Increases BaseXcmWeight for all runtimes. This weight is supposed to account for common operations when we send a XCM message, such as reading the version of the destination chain. I do believe this value was set a bit low, specially based on
https://github.com/paritytech/polkadot/blob/6628e735ef8e1a18786c66622fe711878f682d50/runtime/kusama/src/weights/xcm/pallet_xcm_benchmarks_generic.rs
Although I think some of those writes are only reflected once (e.g., the VersionDiscoveryQueue write), I also feel we should at least double the
baseXcmWeight. We are charging200_000_000per instruction plus thisBaseXcmWeight. and I think for cases where we need to send a message, this might be slidely underestimatedIt also harmonizes the alphanet weight per instruction charged to that of Moonriver and Moonbeam
What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?