Skip to content

Comments

v0.9.18 deps update#1372

Merged
notlesh merged 52 commits intomasterfrom
notlesh-v0.9.18-deps-update
Apr 1, 2022
Merged

v0.9.18 deps update#1372
notlesh merged 52 commits intomasterfrom
notlesh-v0.9.18-deps-update

Conversation

@notlesh
Copy link
Contributor

@notlesh notlesh commented Mar 28, 2022

What does it do?

Updates to Substrate v0.9.18.

Brief status update: I have the runtimes building with an override for evm to point to the unreleased v0.35.0 version.

moonbeams node needs some work.

nimbus needs some work around its parachain-template, although that may not be necessary to make progress for now.

@librelois librelois mentioned this pull request Mar 30, 2022
17 tasks
@girazoki
Copy link
Collaborator

girazoki commented Apr 1, 2022

@notlesh xtokens tests are fixed, I also pointed at a new commit of frontier because the node wasnt building for me, I needed to pass the "with-codec" feature flag for the evm create in evm/primitives

@notlesh notlesh marked this pull request as ready for review April 1, 2022 13:11
Copy link
Collaborator

@girazoki girazoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me as long as we have the CI ready this is an approval

Copy link
Contributor

@tgmichel tgmichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, now that 0.35 is published did you try to remove the evm patch? Not necessary, but curious :)

@notlesh notlesh added B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited dependencies Pull requests that update a dependency file labels Apr 1, 2022
import_queue,
// TODO: plumb this through CLI properly
collator_options: CollatorOptions {
relay_chain_rpc_url: Default::default(),
Copy link
Collaborator

@librelois librelois Apr 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@notlesh does this mean that we can't really test --relay-chain-rpc-url yet ? It matters, because @crystalin wanted us to start testing this feature.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll follow up with a new PR. It shouldn't be difficult.

@notlesh
Copy link
Contributor Author

notlesh commented Apr 1, 2022

lgtm, now that 0.35 is published did you try to remove the evm patch? Not necessary, but curious :)

Haven't tried yet, but it would be great to move off of our custom branch. That could be a quick PR after this, though ;)

@notlesh notlesh merged commit 78db06c into master Apr 1, 2022
@notlesh notlesh deleted the notlesh-v0.9.18-deps-update branch April 1, 2022 18:27
@notlesh notlesh added D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited and removed D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited labels Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants