Skip to content

remove WeightToFee on moonriver#1368

Closed
99Kies wants to merge 2 commits intomoonbeam-foundation:masterfrom
99Kies:master
Closed

remove WeightToFee on moonriver#1368
99Kies wants to merge 2 commits intomoonbeam-foundation:masterfrom
99Kies:master

Conversation

@99Kies
Copy link

@99Kies 99Kies commented Mar 26, 2022

Delete some unused configurations.

@99Kies
Copy link
Author

99Kies commented Mar 28, 2022

@girazoki hi, can you give me some feedback.

@amarsinghcodes
Copy link
Contributor

amarsinghcodes commented Mar 28, 2022

@99Kies the CI returned this error:

  error[E0432]: unresolved import `super::WeightToFee`
    --> /home/gh-actions/runner/_work/moonbeam/moonbeam/runtime/moonriver/src/xcm_config.rs:22:66
     |
  22 |     ParachainInfo, ParachainSystem, PolkadotXcm, Runtime, Treasury, WeightToFee, XcmpQueue,

It seems an import that was removed was used in xcm_config.rs. So add it back please.

@notlesh
Copy link
Contributor

notlesh commented Mar 28, 2022

This will be used again $soon in #1218 (which is waiting for an upstream Substrate PR). It may still be a while before that can be done, though, so removing this is fine for now.

@99Kies
Copy link
Author

99Kies commented Mar 28, 2022

@99Kies CI 返回了这个错误:

  error[E0432]: unresolved import `super::WeightToFee`
    --> /home/gh-actions/runner/_work/moonbeam/moonbeam/runtime/moonriver/src/xcm_config.rs:22:66
     |
  22 |     ParachainInfo, ParachainSystem, PolkadotXcm, Runtime, Treasury, WeightToFee, XcmpQueue,

似乎在 xcm_config.rs 中使用了已删除的导入。所以请加回来。

oh, I lost this problem, sorry.

Copy link
Collaborator

@girazoki girazoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah actually I missed the error because the build wasnt running. So it is being used in xcm

@99Kies
Copy link
Author

99Kies commented Mar 29, 2022

@girazoki In fact, I noticed that transaction_payment does not use the WeightToFee.
So now WeightToFee is mainly used in XCM. Does transaction_payment need to be modified.

https://github.com/PureStake/moonbeam/blob/master/runtime/moonriver/src/lib.rs#L315

@girazoki
Copy link
Collaborator

For now, no. We need to give a good think on what values we want for transaction-payment, and until this is decided, WeightToFee will only be used in xcm

@notlesh
Copy link
Contributor

notlesh commented Mar 30, 2022

Closing since this item is used. It will be used more in the future, as noted.

@notlesh notlesh closed this Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants