This repository was archived by the owner on Oct 9, 2025. It is now read-only.
Update dependencies to polkadot-v0.9.9 series#42
Merged
Conversation
Contributor
Author
|
So the benchmarks seem not to be working / building. I can reproduce the error from the CI with |
Contributor
|
This branch now fails in the fmt too. So far I have been able to figure out that:
|
girazoki
approved these changes
Sep 1, 2021
Contributor
|
This can be merged now |
notlesh
reviewed
Sep 1, 2021
notlesh
approved these changes
Sep 1, 2021
Contributor
notlesh
left a comment
There was a problem hiding this comment.
Looks good. I had a quick question that was worth reviewing.
Also, we may want to re-run benchmarks after our deps update. I can do that, just let me know when.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the dependencies and the Rust toolchain.
This unblocks #26 which I'll also tackle now.