Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report skeleton that lists students in the quiz, and whether they have an in-progress attempt #1

Merged
merged 1 commit into from
Sep 24, 2019

Conversation

HuongNV13
Copy link
Collaborator

Hi @timhunt,

Please help me to review it

The code was tested done by our tester

Thanks,

@HuongNV13 HuongNV13 requested a review from timhunt September 17, 2019 09:10
@HuongNV13 HuongNV13 self-assigned this Sep 17, 2019
@timhunt
Copy link
Member

timhunt commented Sep 23, 2019

This looks great Huong.

I only spotted two very minor things while reviewing:

  1. In version.php, you should probably set a few more properties (for example like https://github.com/moodleou/moodle-quiz_gradingstudents/blob/master/version.php).
  2. In db/install.php, I think that $record->displayorder should be about '5000'; (after standard Moodle manual grading).

Up to you whether you amend this commit to fix those two things, and them wer merge it, or alternatively we put this in now, and you fix those things in a future comment. Up to you how you want to do it.

@HuongNV13
Copy link
Collaborator Author

Thanks Tim for your comment,

I already fixed all the points and squash the commits

Please help me to review it again

Thanks,

@timhunt timhunt merged commit 2b9137d into master Sep 24, 2019
@timhunt
Copy link
Member

timhunt commented Sep 24, 2019

Great. thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants