Fix codechecker errors and update ci workflow

moodleou · Oct 21, 2024 · db191a4 · db191a4
1 parent b92df1f
commit db191a4
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -92,7 +92,7 @@ jobs:
 
       - name: Moodle Code Checker
         if: ${{ always() }}
-        run: moodle-plugin-ci codechecker --max-warnings 0
+        run: moodle-plugin-ci codechecker
 
       - name: Moodle PHPDoc Checker
         continue-on-error: true # This step will show errors but will not fail.

diff --git a/classes/line.php b/classes/line.php
@@ -224,15 +224,15 @@ public static function is_zone_coordinates_valid(string $zone): bool {
      * the start zone and ecx,ecy are the end zone coordinates of a line respectively.
      *
      * @param string $linecoordinates the coordinates for start and end of the line in 'scx,scy ecx,ecy' format.
-     * @param string $lineType the type of the line.
+     * @param string $linetype the type of the line.
      * @return bool
      */
-    public static function are_response_coordinates_valid(string $linecoordinates, string $lineType): bool {
+    public static function are_response_coordinates_valid(string $linecoordinates, string $linetype): bool {
         // If the line-coordinates is empty return false.
         if (trim($linecoordinates) === '') {
             return false;
         }
-        if ($lineType == 'lineinfinite') {
+        if ($linetype == 'lineinfinite') {
             preg_match_all(self::VALIDATE_INFINITE_RESPONSE_COORDINATES, $linecoordinates, $matches, PREG_SPLIT_NO_EMPTY);
         } else {
             preg_match_all(self::VALIDATE_RESPONSE_COORDINATES, $linecoordinates, $matches, PREG_SPLIT_NO_EMPTY);

diff --git a/tests/behat/behat_qtype_drawlines.php b/tests/behat/behat_qtype_drawlines.php
@@ -34,12 +34,12 @@ class behat_qtype_drawlines extends behat_base {
      * @return string the xpath expression.
      */
     protected function line_xpath($line, $part, $iskeyboard = false) {
-        $lineNo = (int)$line - 1;
+        $lineno = (int)$line - 1;
         if ($iskeyboard) {
             if ($part == 'line') {
-                return '//*[name()="svg"]/*[name()="g" and contains(@class, "choice' . $this->escape($lineNo) . '")]';
+                return '//*[name()="svg"]/*[name()="g" and contains(@class, "choice' . $this->escape($lineno) . '")]';
             } else {
-                return '//*[name()="svg"]/*[name()="g" and contains(@class, "choice' . $this->escape($lineNo) . '")]' .
+                return '//*[name()="svg"]/*[name()="g" and contains(@class, "choice' . $this->escape($lineno) . '")]' .
                 '/*[name()="circle" and contains(@class, "' . $this->escape($part) . '")]';
             }
         }