Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,9 @@ jobs:
- php: '8.4'
moodle-branch: 'main'
moodle-app: 'true'
- php: '8.4'
moodle-branch: 'MOODLE_500_STABLE'
moodle-app: 'true'
- php: '8.3'
moodle-branch: 'MOODLE_405_STABLE'
moodle-app: 'true'
Expand Down Expand Up @@ -205,6 +208,9 @@ jobs:
- php: '8.4'
moodle-branch: 'main'
moodle-app: 'true'
- php: '8.4'
moodle-branch: 'MOODLE_500_STABLE'
moodle-app: 'true'
- php: '8.3'
moodle-branch: 'MOODLE_405_STABLE'
moodle-app: 'true'
Expand Down
4 changes: 2 additions & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -95,9 +95,9 @@ jobs:
- MOODLE_BRANCH=main
- MOODLE_APP=true
# Last stable with highest supported PHP version.
- php: 8.3
- php: 8.4
env:
- MOODLE_BRANCH=MOODLE_405_STABLE
- MOODLE_BRANCH=MOODLE_500_STABLE
- MOODLE_APP=true
# And older stable supported (with lowest supported PHP version).
- php: 7.4
Expand Down
3 changes: 3 additions & 0 deletions docs/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ This project adheres to [Semantic Versioning](https://semver.org/).
The format of this change log follows the advice given at [Keep a CHANGELOG](https://keepachangelog.com).

## [Unreleased]
### Changed
- Bump default Selenium version to 4.

## [4.5.7] - 2025-03-26
### Changed
- Allow to run with PHP 8.4 (supported in Moodle 5.0)
Expand Down
4 changes: 2 additions & 2 deletions src/Command/BehatCommand.php
Original file line number Diff line number Diff line change
Expand Up @@ -223,13 +223,13 @@ private function getSeleniumImage(InputInterface $input, string $profile): strin
}

if ($profile === 'chrome') {
return getenv('MOODLE_APP') ? 'selenium/standalone-chrome:120.0' : 'selenium/standalone-chrome:3';
return 'selenium/standalone-chrome:4';
}

if ($this->usesLegacyPhpWebdriver()) {
return 'selenium/standalone-firefox:2.53.1';
}

return 'selenium/standalone-firefox:3';
return 'selenium/standalone-firefox:4';
}
}
4 changes: 2 additions & 2 deletions tests/Command/BehatCommandTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ public function testExecuteWithChromeProfile()

$commandTester = $this->executeCommand(null, null, ['--start-servers' => true, '--profile' => 'chrome']);
$this->assertSame(0, $commandTester->getStatusCode());
$this->assertMatchesRegularExpression('/selenium\/standalone-chrome:3/', $this->allCmds[1]);
$this->assertMatchesRegularExpression('/selenium\/standalone-chrome:4/', $this->allCmds[1]);
}

public function testExecuteWithFirefoxProfile()
Expand All @@ -104,7 +104,7 @@ public function testExecuteWithFirefoxProfile()

$commandTester = $this->executeCommand(null, null, ['--start-servers' => true, '--profile' => 'firefox']);
$this->assertSame(0, $commandTester->getStatusCode());
$this->assertMatchesRegularExpression('/selenium\/standalone-firefox:3/', $this->allCmds[1]);
$this->assertMatchesRegularExpression('/selenium\/standalone-firefox:4/', $this->allCmds[1]);
}

public function testExecuteWithLegacyFirefoxProfile()
Expand Down
Loading