Skip to content

Conversation

@kabalin
Copy link
Member

@kabalin kabalin commented Jan 31, 2025

No description provided.

@codecov
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.26%. Comparing base (d9ebaf9) to head (8b2385d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #339   +/-   ##
=========================================
  Coverage     88.26%   88.26%           
  Complexity      761      761           
=========================================
  Files            77       77           
  Lines          2335     2335           
=========================================
  Hits           2061     2061           
  Misses          274      274           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kabalin kabalin requested a review from paulholden January 31, 2025 13:23
@paulholden paulholden merged commit f31fea1 into moodlehq:main Jan 31, 2025
27 of 28 checks passed
@stronk7
Copy link
Member

stronk7 commented Jan 31, 2025

Note to us: Per the release process it's better to avoid merging these release PRs, instead, use cherrypick/rebase (whatever they are called in GH). That way we can tag on the changes commit, not on the merge one.

PS: Note it's not critical at all, it's just better (less ugly), hence sharing. Thanks for proceeding!

@kabalin kabalin deleted the release branch January 31, 2025 14:45
@kabalin
Copy link
Member Author

kabalin commented Jan 31, 2025

It's me who forgot to mention in the comments not to merge it :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants