SAML-14: Fixed fatal error due to course shortname. #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A fatal error could be triggered by course shortnames with characters that are valid in shortnames but not valid in admin settings. Invalid characters will now be filtered out.
|
I made a small update to the previous commit, since one of our support staff ran into a issue with course shortnames that were too long. I added a substr call to limit the admin setting to using the first 60 characters of the string after the invalid characters have been stripped out. |
|
This issue has now been addressed by a July 16th commit that took a more expansive approach to fixing the problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fatal error could be triggered by course shortnames with
characters that are valid in shortnames but not valid in
admin settings. Invalid characters will now be filtered out.