Better summary and impact updates #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, the summary and impact commands would overwrite whatever was currently set for the incident. In most cases, our understanding of these develops over time, so we'd like to be update and refine what we've previously set. This change introduces actions and dialogs to update the summary and impact from what was previously set, making it easier for us to develop meaningful and thorough statements over time.
ChrisAnn
suggested changes
Nov 15, 2019
| PROPOSED_MESSAGE_BLOCK_ID = "proposed" | ||
| UPDATE_IMPACT_DIALOG = "update-impact-dialog" | ||
|
|
||
| NO_IMPACT_TEXT = "The impact of this incicent hasn't been set yet." |
There was a problem hiding this comment.
Suggested change
| NO_IMPACT_TEXT = "The impact of this incicent hasn't been set yet." | |
| NO_IMPACT_TEXT = "The impact of this incident hasn't been set yet." |
ChrisAnn
approved these changes
Nov 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, the summary and impact commands would overwrite whatever was currently
set for the incident. In most cases, our understanding of these develops over time, so we'd
like to be update and refine what we've previously set.
This change introduces actions and dialogs to update the summary and impact from what was previously
set, making it easier for us to develop meaningful and thorough statements over time.