Skip to content

feat: replace Airbnb ESLint rules with standard configurations #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: replace Airbnb ESLint rules with standard configurations #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion next.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ module.exports = {
},
extends: [
'next/core-web-vitals',
'airbnb',
'eslint:recommended',
'plugin:@typescript-eslint/recommended',
'eslint-config-prettier'
Expand Down
1 change: 0 additions & 1 deletion node.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ module.exports = {
}
},
extends: [
'airbnb-base',
'eslint:recommended',
'plugin:@typescript-eslint/recommended',
'prettier'
Comment on lines 16 to 18
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The eslint-plugin-n package has been added to package.json with the intent of providing enhanced Node.js linting, which is great. However, it doesn't seem to be activated in this ESLint configuration file for Node.js projects.

To leverage the rules from eslint-plugin-n, you would typically add its recommended configuration to the extends array. Could we update the extends array to include plugin:n/recommended?

For example:

extends: [
  'eslint:recommended',
  'plugin:@typescript-eslint/recommended',
  'plugin:n/recommended', // For Node.js specific rules
  'prettier'
],

This will ensure that the rules from eslint-plugin-n are applied, fulfilling the goal of enhanced Node.js linting.

		'eslint:recommended',
		'plugin:@typescript-eslint/recommended',
		'plugin:n/recommended', // Activate Node.js specific linting rules
		'prettier'

Expand Down
3 changes: 1 addition & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
"@types/inquirer": "^9.0.3",
"@types/node": "^20.4.5",
"eslint": "^8.46.0",
"eslint-plugin-n": "^17.18.0",
"husky": "^8.0.3",
"standard-version": "^9.5.0",
"typescript": "^5.1.6"
Expand All @@ -38,8 +39,6 @@
"@inquirer/prompts": "^3.0.0",
"@typescript-eslint/eslint-plugin": "^7.0.2",
"@typescript-eslint/parser": "7.0.2",
"eslint-config-airbnb": "^19.0.4",
"eslint-config-airbnb-base": "^15.0.0",
"eslint-config-next": "^14.1.0",
"eslint-config-prettier": "^9.1.0",
"eslint-import-resolver-typescript": "^3.6.1",
Expand Down
Loading
Loading