Error "unsupported type; ..." with map[string]*struct #43

darigaaz · 2021-01-30T17:20:02Z

fixed #42

darigaaz · 2021-01-30T17:32:04Z

formam.go

@@ -295,19 +295,10 @@ func (dec *Decoder) traverse() error {
 			dec.traverseInMap(true)
 		}
 		dec.field = ""
+
+		dec.traverseIndirect()


I believe it must be nested in both cases dec.field != "" and dec.index != ""
otherwise calls to dec.traverse() with empty field and index changes decoder state if dec.curr points to some reflect.Pointer

fixed monoculum#42

darigaaz commented Jan 30, 2021

View reviewed changes

darigaaz mentioned this pull request Jan 30, 2021

Improve analyzePath #39

Closed

darigaaz and others added 2 commits January 31, 2021 16:03

Error "unsupported type; ..." with map[string]*struct

01241b7

fixed monoculum#42

Clarify a few comments

f8532c1

arp242 force-pushed the allow_pointers_in_maps branch from 0f7412b to f8532c1 Compare January 31, 2021 08:11

arp242 approved these changes Jan 31, 2021

View reviewed changes

arp242 merged commit 41b48e2 into monoculum:master Jan 31, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Error "unsupported type; ..." with map[string]*struct #43

Error "unsupported type; ..." with map[string]*struct #43

darigaaz commented Jan 30, 2021

darigaaz Jan 30, 2021

Error "unsupported type; ..." with map[string]*struct #43

Error "unsupported type; ..." with map[string]*struct #43

Conversation

darigaaz commented Jan 30, 2021

darigaaz Jan 30, 2021

Choose a reason for hiding this comment