Closed
Conversation
This moves to net8 the latest LTS version from Microsoft. Also enables: * NETAnalyzers * Deterministic builds * Global TreatWarningsAsErrors
Also added .idea for Project Rider
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the project from .NET 6 to .NET 8 and enables new build options.
- Removed legacy serialization code from exception classes.
- Updated GitHub workflows to target .NET 8.
Reviewed Changes
Copilot reviewed 8 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/TaglibSharp/UnsupportedFormatException.cs | Removed serialization support attributes and constructors. |
| src/TaglibSharp/Riff/List.cs | Removed serialization and COM attributes and related constructors. |
| src/TaglibSharp/File.cs | Removed legacy serialization helper; rethrowing inner exceptions now may lose stack trace. |
| src/TaglibSharp/CorruptFileException.cs | Removed serialization support attributes and constructors. |
| .github/workflows/windows.yml | Updated .NET version from 6.0.302 to 8.0.100 in CI workflow. |
| .github/workflows/ubuntu.yml | Updated .NET version from 6.0.302 to 8.0.100 in CI workflow. |
| .github/workflows/mac.yml | Updated .NET version from 6.0.302 to 8.0.100 in CI workflow. |
Files not reviewed (2)
- Directory.Build.props: Language not supported
- src/TaglibSharp/TaglibSharp.csproj: Language not supported
Comments suppressed due to low confidence (1)
src/TaglibSharp/File.cs:1300
- Re-throwing an inner exception using 'throw e.InnerException;' resets the original stack trace. Consider using 'ExceptionDispatchInfo.Capture(e.InnerException).Throw();' to preserve the original stack trace.
throw e.InnerException;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move net6 to net8 and enable a couple build items
This moves to net8 the latest LTS version from Microsoft.
Also enables:
/cc @xaviergxf I created a similar PR to your #335 but with the serialization stuff removed.