Update skia to m53 - #15
Merged
Merged
Conversation
fiddle showing bug: https://fiddle.skia.org/c/a21ecf5e33da84f52eba26e8c2f3d280 BUG=skia:5408 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2060543002 Review-Url: https://codereview.chromium.org/2060543002
This is purely for convenience, to not need to write the lock type in the guard anymore. This should all inline away. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2055023003 Review-Url: https://codereview.chromium.org/2055023003
Non-platform code needs this information in order to make rendering decisions. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2062443002 Review-Url: https://codereview.chromium.org/2062443002
TBR=mtklein@chormium.org GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2058343002 Review-Url: https://codereview.chromium.org/2058343002
BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2061553002 TBR= Review-Url: https://codereview.chromium.org/2061553002
Automatic commit by the RecreateSKPs bot. TBR= NO_MERGE_BUILDS GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2065433003 Review-Url: https://codereview.chromium.org/2065433003
Tried to comment my logic, but it's totally possible that we run on some device where this doesn't work. From a strict reading of the relevant specs, what I'm doing shouldn't work on the Nexus 5X, but it's necessary to get correct results. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2054223002 Review-Url: https://codereview.chromium.org/2054223002
Switch to new SkSourceGammaTreatment type. Move to a separate setter, rather than an optional argument to dirty. Set the flag correctly after uploading CPU-built mips. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2058143002 Review-Url: https://codereview.chromium.org/2058143002
This adds support with animation, assuming the sample has implemented onAnimate. Event handling has not been implemented. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2056343004 Review-Url: https://codereview.chromium.org/2056343004
…le when called from GrShape. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2055253002 Review-Url: https://codereview.chromium.org/2055253002
This code was running on our bots but never in Chrome. That's a bad state to be in. My plan here use to be to redesign how our 8888 blits worked in SSE 4.1, mainly for perfect correctness but also for speed, then to spread what I learned there to SSE2, AVX+, and NEON. I have since lost interest in changing any aspect of how our legacy 8888 blits work. There's not much point in making them a bit or two more correct when the math is fundamentally wrong. This will cause many diffs in Gold, none perceptible. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2062853002 CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Review-Url: https://codereview.chromium.org/2062853002
Currently, Skia always uploads GPU textures at full resolution. This change allows us to pass a pre-scale mip level to the deferred texture image logic, which causes us to pre-scale the image to the given mip level, and upload that mip level instead of the full image. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2007113008 Review-Url: https://codereview.chromium.org/2007113008
BUG=skia:5428 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2061783002 Review-Url: https://codereview.chromium.org/2061783002
https://codereview.chromium.org/2030683002/ ) Reason for revert: serialize-8888 broken for typefacestyles on Mac. (Bold weighting goes missing.) Original issue's description: > Update typeface serialization style. > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2030683002 > > Committed: https://skia.googlesource.com/skia/+/7ae1c72e593823e6e300e4199558555765bcec17 TBR=reed@google.com,bungeman@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2067583002
…ereview.chromium.org/2056343004/ ) Reason for revert: breaking on android compile Original issue's description: > Add samples to Viewer. > > This adds support with animation, assuming the sample has > implemented onAnimate. Event handling has not been > implemented. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2056343004 > > Committed: https://skia.googlesource.com/skia/+/76963e73704a42a18c29d6fbdcccb566e5c67658 TBR=bsalomon@google.com,jvanverth@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review-Url: https://codereview.chromium.org/2063883002
…:1 of https://codereview.chromium.org/2062853002/ ) Reason for revert: Breaks a couple Google3 goldens. I need to rebaseline google3 with -DSK_SUPPORT_LEGACY_X86_BLITS first, then reland this. Original issue's description: > Clean up two unlaunched SSE 4.1 8888 blits. > > This code was running on our bots but never in Chrome. > That's a bad state to be in. > > My plan here use to be to redesign how our 8888 blits worked in SSE 4.1, mainly > for perfect correctness but also for speed, then to spread what I learned there > to SSE2, AVX+, and NEON. > > I have since lost interest in changing any aspect of how our legacy 8888 blits > work. There's not much point in making them a bit or two more correct when the > math is fundamentally wrong. > > This will cause many diffs in Gold, none perceptible. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2062853002 > CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot > > Committed: https://skia.googlesource.com/skia/+/6e472093009bf2fc4a8e53010b51040efcb71213 TBR=reed@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review-Url: https://codereview.chromium.org/2066453003
TBR=egdaniel@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2062943002 Review-Url: https://codereview.chromium.org/2062943002
BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2058753002 Review-Url: https://codereview.chromium.org/2058753002
BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2060823004 Review-Url: https://codereview.chromium.org/2060823004
BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2029763002 Review-Url: https://codereview.chromium.org/2029763002
TBR=egdaniel@google.com So Visual Studio won't complain. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2064863002 Review-Url: https://codereview.chromium.org/2064863002
switch is already handling all cases, but some compilers don't care. This suppresses errors about potentially using vkLoadOp and vkStoreOp uninitialized. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2068523002 Review-Url: https://codereview.chromium.org/2068523002
Fixes crash when switching to sRGB mode on Nexus 9, among others. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2066743003 Review-Url: https://codereview.chromium.org/2066743003
BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2069633002 TBR=egdaniel@google.com Review-Url: https://codereview.chromium.org/2069633002
BUG=skia: TBR=egdaniel@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2069443003 Review-Url: https://codereview.chromium.org/2069443003
TBR=egdaniel@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2061123003 Review-Url: https://codereview.chromium.org/2061123003
This hasn't compiled for months. We are deemphasizing SampleApp in favor of viewer. Windowed command buffer is not currently something we currently plan to maintain. TBR=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2061233002 Review-Url: https://codereview.chromium.org/2061233002
SkPicture::cullRect() is not guaranteed to be the same as the bounds passed to SkPictureRecorder::beginRecording(). Review-Url: https://codereview.chromium.org/2067473003
- mono/SkiaSharp#114 - "An internal error has occurred in the compiler."
# Conflicts: # gyp/common_conditions.gypi # gyp/dng_sdk.gyp # include/core/SkPreConfig.h # src/gpu/gl/GrGLGpu.cpp # src/gpu/text/GrAtlasTextBlob_regenInBatch.cpp # tests/PathOpsBuilderTest.cpp
----------- Initialize fGammaCorrect in DF Path Renderer unit test TBR=jvanverth@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2157933003 Review-Url: https://codereview.chromium.org/2157933003 Fix leak when DFPR fails to draw path TBR=jvanverth@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2144283002 Review-Url: https://codereview.chromium.org/2144283002 Make GrBatchAtlas robust against attempts to add large rects. Make GrAADistanceFieldPathRenderer robust against paths that in src space wind up being too large for the atlas. BUG=chromium:627443 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2144663004 Review-Url: https://codereview.chromium.org/2144663004 NOTREECHECKS=true NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2160563004
…can run tests. ----- Convert SK Images to new assets format Depends on https://codereview.chromium.org/2162563002/ BUG=skia:5427 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2155163002 Review-Url: https://codereview.chromium.org/2155163002 ----- Add Android SDK asset This will allow us to use CIPD to install the Android SDK on bots. BUG=skia:5427 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2086003002 Review-Url: https://codereview.chromium.org/2086003002 ----- Convert Win toolchain to CIPD package BUG=skia:5427 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2111713003 Review-Url: https://codereview.chromium.org/2111713003 ----- NOTREECHECKS=true NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2159213002
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2164313002 NOTREECHECKS=true NOTRY=true NOPRESUBMIT=true TBR=egdaniel@google.com Review-Url: https://codereview.chromium.org/2164313002
mattleibow
pushed a commit
that referenced
this pull request
Nov 18, 2016
…dable (patchset #15 id:280001 of https://codereview.chromium.org/2488523003/ ) Reason for revert: bots crashing / asserting Original issue's description: > Make SkSmallAllocator obey the RAII invariants and move to heap structures when needed. > > The biggest change is to the API which allowed code to bypass the > destruction invariants. This destruction bypass feature was needed in > only one use, and is totally encapsulated using createWithIniterT. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2488523003 > > Committed: https://skia.googlesource.com/skia/+/d5dc657b8c3ac916f98005dafdedafe02f023449 > Committed: https://skia.googlesource.com/skia/+/c18b5f8f57a4efc5d5d1e399ed8bd3bd02c592ab TBR=bungeman@google.com,herb@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review-Url: https://codereview.chromium.org/2494353002
Et7f3
pushed a commit
to Et7f3/esy-skia
that referenced
this pull request
Apr 29, 2020
Et7f3
pushed a commit
to Et7f3/esy-skia
that referenced
this pull request
Jun 25, 2020
Et7f3
pushed a commit
to Et7f3/esy-skia
that referenced
this pull request
Jun 25, 2020
* Add FontCache * Add fontcache * Use cached font loading * Add fontFamily / fontSize to text styles
Et7f3
pushed a commit
to Et7f3/esy-skia
that referenced
this pull request
Jun 27, 2020
Et7f3
pushed a commit
to Et7f3/esy-skia
that referenced
this pull request
Aug 8, 2020
mattleibow
pushed a commit
that referenced
this pull request
Aug 14, 2023
This was a workaround for an Apple clang bug that no longer appears to be relevant. That's good, because the workaround was somewhat dangerous (potential to trigger seg-faults on uncommitted stack pages). See comment #15 on the linked bug for a detailed explanation. Bug: skia:9709 Change-Id: I6489b8ddbcf042e6ebc24065a866373bf64a6064 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/703681 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have merged the Xamarin C API into the Google folders. As we now have far more coverage than Google, I will take preference with our code.