This repository has been archived by the owner on Aug 8, 2024. It is now read-only.
[mono] Fix regresion for XA (issue #1845) (#69) #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TargetFrameworks on osx have a default fallback search path:
`/Library/Frameworks/Mono.framework/External/xbuild-frameworks`
This was earlier implemented in mono/msbuild via the app.config, but
then was changed to be specified via the property
`$(TargetFrameworkFallbackSearchPaths)`. And passed to
`GetReferenceAssemblyPaths` task via a new parameter
`TargetFrameworkFallbackSearchPaths`.
This also means that if any user of `GetReferenceAssemblyPaths` does not
use this new parameter, then on osx, msbuild won't be using any fallback
search path. In msbuild's targets files, we pass the new property as
argument for the new GRAP task parameter.
Accordingly, any non-msbuild users(targets) will need to update their
use of GRAP task to get the search path. But this would break any
existing/older users which are not using the new parameter and suddenly
find that projects won't build because of the missing search path.
Existing versions of Xamarin.Android are one example.
To ensure that they can continue working, we internally use the fallback
path if nothing is passed to the task. This can be disabled by setting
`DISABLE_FALLBACK_PATHS_HACK_IN_GRAP_OSX` env var.
Fixes dotnet/android#1845
(cherry picked from commit 8af44c5)
akoeplinger
approved these changes
Aug 28, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TargetFrameworks on osx have a default fallback search path:
This was earlier implemented in mono/msbuild via the app.config, but
then was changed to be specified via the property
$(TargetFrameworkFallbackSearchPaths). And passed toGetReferenceAssemblyPathstask via a new parameterTargetFrameworkFallbackSearchPaths.This also means that if any user of
GetReferenceAssemblyPathsdoes notuse this new parameter, then on osx, msbuild won't be using any fallback
search path. In msbuild's targets files, we pass the new property as
argument for the new GRAP task parameter.
Accordingly, any non-msbuild users(targets) will need to update their
use of GRAP task to get the search path. But this would break any
existing/older users which are not using the new parameter and suddenly
find that projects won't build because of the missing search path.
Existing versions of Xamarin.Android are one example.
To ensure that they can continue working, we internally use the fallback
path if nothing is passed to the task. This can be disabled by setting
DISABLE_FALLBACK_PATHS_HACK_IN_GRAP_OSXenv var.Fixes dotnet/android#1845
(cherry picked from commit 8af44c5)