Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CoreFX import for ProtectedData type (Windows part) #9375

Merged
merged 5 commits into from
Jul 9, 2018
Merged

CoreFX import for ProtectedData type (Windows part) #9375

merged 5 commits into from
Jul 9, 2018

Conversation

MaximLipnin
Copy link
Contributor

As part of #7589

@filipnavara
Copy link
Contributor

Is there still any point in having NativeDapiProtection.cs?

@MaximLipnin
Copy link
Contributor Author

no, I will delete it, thanks

marek-safar
marek-safar reviewed Jun 29, 2018
View reviewed changes
mcs/class/System.Security/win32_System.Security.dll.sources
@@ -0,0 +1,11 @@
#include System.Security.dll.sources
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update also winaot profile

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@MaximLipnin
Copy link
Contributor Author

Seems that xunit tests for ProtectedData need to be extracted to some separate test profiles for win32/winaot.

@MaximLipnin
Copy link
Contributor Author

At the moment I don't know what exactly test profile naming should be used.

@MaximLipnin
CoreFX import for ProtectedData type (Windows part): temporarily comm…
e6c03af 
…ent out xunit tests because they are Windows-specific and there is no support for platform-specific xunit test sources.
@MaximLipnin
Copy link
Contributor Author

#9395

@filipnavara
Copy link
Contributor

At least on macOS the tests that failed show an actual problem with the managed implementation. I don't necessarily think it has to be solved within this PR, but there should probably be an issue tracking it. The path that the functions try to access on macOS is protected and read-only, maybe "/usr/local" instead of "/usr" would work.

@MaximLipnin
Copy link
Contributor Author

#9399 "ManagedProtection: System.UnauthorizedAccessException on MacOS"

@marek-safar
Copy link
Member

@monojenkins commit csproj

@marek-safar marek-safar merged commit f602125 into mono:master Jul 9, 2018
@MaximLipnin MaximLipnin deleted the System.Security_ProtectedData_corefx_import branch July 10, 2018 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marek-safar marek-safar marek-safar approved these changes

@akoeplinger akoeplinger Awaiting requested review from akoeplinger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MaximLipnin @filipnavara @marek-safar @monojenkins