Fix remoting type checking #21700
Open
Fix remoting type checking #21700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Method calls on a generic types produce the "RemotingException: Cannot cast from client type 'X' to server type 'Y'" if they have 2+ layers deep generic arguments, such as A<B<C>> The GetTypeNameFromAssemblyQualifiedName would incorrectly trim the type name and that will cause the CastTo method to return null and throw the exception down the line. Example of such incorrect trimming: A`1[[B`1[[C, assembly]], assembly]], assembly becomes A`1[[B`1[[C, assembly]] This is incorrect and would not match any type ever. It should instead be trimmed to this: A`1[[B`1[[C, assembly]], assembly]]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a bug report and a fix proposal at the same time.
The bug
Remoting method calls on a generic types produce the "RemotingException: Cannot cast from client type 'X' to server type 'Y'" if the type has 2+ layers deep generic arguments, such as A<B<C>>
The GetTypeNameFromAssemblyQualifiedName method would incorrectly trim the type name and that will cause the CastTo method to return null and throw the exception down the line. Example of such incorrect trimming:
A'1[[B'1[[C, assembly]], assembly]], assemblybecomes
A'1[[B'1[[C, assembly]]This is incorrect and would not match any type ever. It should instead be trimmed to this:
A'1[[B'1[[C, assembly]], assembly]]The fix
The GetTypeNameFromAssemblyQualifiedName method should use the LastIndexOf instead of IndexOf when searching for "]]"
Warning
I tested this fix only on Windows platform in kind of very specific use case so i do not guarantee that this fix is universal for everyone and would not break anything. Someone test my fix properly if you able, please.