Unable to inspect ReadOnlySpan<char> in debugger #12374

Therzok · 2019-01-11T10:23:03Z

Steps to Reproduce

Have an application with ReadOnlySpan being used

var span = "asdf".AsSpan();

Given a StructMirror invoke of ReadOnlySpan<char>.ToString(), it'll fail with an INVALID_ARGUMENT error code.
Maybe ref structs need to be specialized in the debugger when passed?

Current Behavior

We should get the string.

Expected Behavior

INVALID_ARGUMENT error code

On which platforms did you notice this

[x] macOS
[ ] Linux
[ ] Windows

Version Used:

Mono JIT compiler version 5.18.0.223 (2018-08/3f799cc3c78 Wed Dec 19 22:12:52 EST 2018)
Copyright (C) 2002-2014 Novell, Inc, Xamarin Inc and Contributors. www.mono-project.com
	TLS:
	SIGSEGV:       altstack
	Notification:  kqueue
	Architecture:  amd64
	Disabled:      none
	Misc:          softdebug
	Interpreter:   yes
	LLVM:          yes(600)
	Suspend:       preemptive
	GC:            sgen (concurrent by default)

Stacktrace

Please paste the stack trace here if available.

The text was updated successfully, but these errors were encountered:

Therzok · 2019-01-11T10:23:49Z

cc @thaystg

marek-safar · 2019-01-11T10:34:38Z

Yes, this looks like ref struct issue

…y field of the Class has the type of the field different of the value of the field because the assign was done in an unsafe way like this: Now the datatypes check are only executed when it's not inside an invoke method. _pinnable = Unsafe.As<Pinnable<T>>(array); A unit test that reproduces the issue was created either. Fixes mono#12374

…y field of the Class has the type of the field different of the value of the field because the assign was done in an unsafe way like this: Now the datatypes check are not executed only when each field of the class is been checked before the invoke method.. _pinnable = Unsafe.As<Pinnable<T>>(array); A unit test that reproduces the issue was created either. Fixes mono#12374

…fe value (#12394) * [Debugger] Debugger failure when a method is called in watches and any field of the Class has the type of the field different of the value of the field because the assign was done in an unsafe way like this: Now the datatypes check in the fields are only executed when it's not inside an invoke method. _pinnable = Unsafe.As<Pinnable<T>>(array); A unit test that reproduces the issue was created either. Fixes #12374

…hes and any field of the Class has the type of the field different of the value of the field because the assign was done in an unsafe way like this: Now the datatypes check are not executed only when each field of the class is been checked before the invoke method.. _pinnable = Unsafe.As<Pinnable<T>>(array); A unit test that reproduces the issue was created either. Fixes mono#12374

…hes and any field of the Class has the type of the field different of the value of the field because the assign was done in an unsafe way like this: Now the datatypes check are not executed only when each field of the class is been checked before the invoke method.. _pinnable = Unsafe.As<Pinnable<T>>(array); A unit test that reproduces the issue was created either. Fixes #12374

marek-safar added the area-Debugger label Jan 11, 2019

thaystg self-assigned this Jan 11, 2019

thaystg mentioned this issue Jan 12, 2019

[Debugger] Debugger failure when field content is assigned by an unsafe value #12394

Merged

thaystg closed this as completed in #12394 Jan 15, 2019

marek-safar added this to the 2018-12 (5.22.xx) milestone Jan 28, 2019

thaystg mentioned this issue Jan 28, 2019

[2018-12][debugger][backport] Debugger failure when field content is assigned by an unsafe value #12661

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Unable to inspect ReadOnlySpan<char> in debugger #12374

Unable to inspect ReadOnlySpan<char> in debugger #12374

Therzok commented Jan 11, 2019

Therzok commented Jan 11, 2019

marek-safar commented Jan 11, 2019

Unable to inspect ReadOnlySpan<char> in debugger #12374

Unable to inspect ReadOnlySpan<char> in debugger #12374

Comments

Therzok commented Jan 11, 2019

Steps to Reproduce

Current Behavior

Expected Behavior

On which platforms did you notice this

Stacktrace

Therzok commented Jan 11, 2019

marek-safar commented Jan 11, 2019