This repository was archived by the owner on Sep 4, 2024. It is now read-only.
Use Environment.SpecialFolder.UserProfile instead of Personal #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mono and .NET, before .NET 8, would resolve the System.Environment.SpecialFolder.Personal enum value to the $HOME directory. In .NET 8 this is changing. The Personal folder will now refer to $XDG_DOCUMENTS_DIR if set or $HOME/Documents otherwise. Replace all uses of Environment.SpecialFolder.Personal with Environment.SpecialFolder.UserProfile so the code behaves as it did before. UserProfile still maps to $HOME dotnet/runtime#68610
Therzok
approved these changes
Sep 20, 2022
slluis
approved these changes
Sep 20, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mono and .NET, before .NET 8, would resolve the
System.Environment.SpecialFolder.Personal enum value to the $HOME directory. In .NET 8 this is changing. The Personal folder will now refer to $XDG_DOCUMENTS_DIR if set or $HOME/Documents otherwise.
Replace all uses of Environment.SpecialFolder.Personal with Environment.SpecialFolder.UserProfile so the code behaves as it did before. UserProfile still maps to $HOME
dotnet/runtime#68610
Note: Not sure this is needed - only looks like SpecialFolder.Personal is only used in gtk# UI and mono is not being updated with this change.