Fix release-notes classifier mis-tagging skia-sync PRs; make path tags data-driven

[mattleibow]

Problem

The release-notes generator (scripts/infra/docs/release-notes-data.py) tags every merged PR product / mixed / internal from the files it touched, so the Polish phase can focus on product changes. Automated [skia-sync] submodule bumps — which change the shipped native Skia — kept coming out internal and being dropped from the notes (e.g. 4.151.0-unreleased.data.json tags #4382 and 4.148.1-unreleased tags #4262 internal, despite both bumping externals/skia).

Root cause (commit 1)

_files_by_commit() runs git log --format=%x1e%H --name-only and parsed each record by matching a leading \x1e per line. But:

1. run() returns result.stdout.strip(), and \x1e (record separator) is whitespace to Python's str.strip(), so the leading \x1e on the first record is stripped off.
2. git log lists commits newest-first, so that first, separator-less record is the newest commit in the range — very often the latest [skia-sync] bump.

The line.startswith("\x1e") check then missed that commit, its file list was dropped, and an empty file set falls through to internal.

Fix: parse by splitting on \x1e, which recovers every record regardless of the stripped leading separator.

Sharpen the path tiers (commit 2)

• product (real API/behaviour/native change): binding/ + source/ (managed API & Views) and externals/skia — exact, not externals/, so it no longer sweeps in the sibling externals/depot_tools build toolchain or externals/.gitignore.
• mixed (affects the package, judged from the title): native/ (per-platform build config; incl. the shipped WinUI native subtree under native/winui/) and docs (the mono/SkiaSharp-API-docs submodule XML — moved up from internal; slash-less prefix to match the bare gitlink without colliding with documentation/).
• internal: CI, workflows, agent skills, the docs site (documentation/), tests, samples, build/meta, and externals/depot_tools.

Make the mapping data-driven (commit 3)

The path→tag mapping is no longer hardcoded in the script. It now lives in scripts/infra/docs/release-notes-paths.json — ordered tiers (tag + patterns) plus a default — the single deterministic place to edit it:

{ "tiers": [ { "tag": "product", "patterns": ["binding/", "source/", "externals/skia"] },
             { "tag": "mixed",   "patterns": ["native/", "docs"] } ],
  "default": "internal" }

_pr_category loads the tiers (cached) and returns the first tier with a matching file, else the default. A pattern matches by prefix (str.startswith, unchanged behaviour) or, if it contains a glob metachar (* ? [), by fnmatch.fnmatchcase — so paths, prefixes, and wildcards are all supported. A missing/malformed config is a hard error (no silent fallback). Behaviour is identical to the previous hardcoded tuples.

Verification

PR / path	tag
#4382 [skia-sync] Merge upstream chrome/m151	product
#4294 [skia-sync] Update Skia to milestone m151	product
#4325 Update docs submodule to latest main	mixed
externals/depot_tools-only / externals/.gitignore	internal
#3209 depot_tools + native/	mixed
native/-only	mixed
#4292 docs: … site page (documentation/)	internal

Config loads from disk, glob patterns work (fnmatch), a broad ~40-commit range stays a healthy mix, and the module compiles clean.

Notes

• Committed historical *.data.json self-correct as pages regenerate on the next prepare.sh / scheduled release-notes run. No _DATA_JSON_FORMAT_VERSION bump (schema unchanged).
• Docs updated: documentation/dev/release-notes-and-api-diffs.md (incl. the config-file inventory) and .agents/skills/release-notes/SKILL.md.

Co-authored-by: Copilot App 223556219+Copilot@users.noreply.github.com

[github-actions]

📦 Try the packages from this PR

Warning

Do not run these scripts without first reviewing the code in this PR.

Step 1 — Download the packages

bash / macOS / Linux:

curl -fsSL https://raw.githubusercontent.com/mono/SkiaSharp/main/scripts/get-skiasharp-pr.sh | bash -s -- 4410

PowerShell / Windows:

iex "& { $(irm https://raw.githubusercontent.com/mono/SkiaSharp/main/scripts/get-skiasharp-pr.ps1) } 4410"

Step 2 — Add the local NuGet source

dotnet nuget add source ~/.skiasharp/hives/pr-4410/packages --name skiasharp-pr-4410

More options

Option	Description
--successful-only / -SuccessfulOnly	Only use successful builds
--force / -Force	Overwrite previously downloaded packages
--list / -List	List available artifacts without downloading
--build-id ID / -BuildId ID	Download from a specific build

Or download manually from Azure Pipelines — look for the nuget artifact on the build for this PR.

Remove the source when you're done:

dotnet nuget remove source skiasharp-pr-4410

[github-actions]

📖 Documentation Preview

The documentation for this PR has been deployed and is available at:

🔗 View Staging Site
🔗 View Staging Docs
🔗 View Staging Gallery (Blazor)
🔗 View Staging Gallery (Uno Platform)
🔗 View Staging SkiaFiddle

This preview will be updated automatically when you push new commits to this PR.

---

This comment is automatically updated by the documentation staging workflow.