Fixes WPF SKGLElement has memory leaks#3311
Open
beto-rodriguez wants to merge 2 commits into
Open
Conversation
This update makes it easier to clear memory leaks.
Contributor
|
Hey there @@beto-rodriguez! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
This was referenced Jul 19, 2025
mattleibow
added a commit
that referenced
this pull request
Jul 3, 2026
Audit of all 11 families for over-specific/live targets that would let the agent copy an answer instead of investigating: - Family 4 (fixed-pointer): replace the "real, still-unfixed Blob.FromStream" worked example with a synthetic non-copying-native example; demote Blob.FromStream to a bare #3472/PR #3473 citation. Same for the SKILL.md cheat-sheet row 4. - Family 3 (Views): drop the embedded live SKGLElement / open-PR #3311 diagnosis from "Real cases"; keep the issue numbers only. - Family 6 (clone double-free): genericize the SKPaint.Clone example to a neutral SKThing/sk_thing_clone wrapper; keep #2904 citation. Remaining real symbols are all safe: documented same-instance contracts (family 2), already-fixed issue citations, or correct reference implementations to mirror (families 7-10). No un-fixed target is handed to the agent as a worked answer. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates OpenTK dependency with a version that at least includes opentk/GLWpfControl#126, finally when
SKGLElementis disposed, the baseGLWpfControlis also disposed.The pair of versions picked
OpenTK 4.9.4andOpenTK.GLWpfControl 4.3.3was the oldest pair that worked for me out of the box.Bugs Fixed
API Changes
None.
Behavioral Changes
When SKGLElement is disposed, the base class is also disposed.
Required skia PR
None.
PR Checklist