Enable GL on Windows ARM#3189
Merged
Merged
Conversation
Contributor
Author
|
The good new s is that this now works! But, the views do not as the yare using OpenTK which uses glfw, and that is not yet built for ARM. I will play with that, but chances are for now we will wait for glfw/glfw#2163 |
3 tasks
Contributor
Author
|
Hi folks, The builds are now available on the preview feed: https://aka.ms/skiasharp-eap/index.json As soon as you let me know, I can release this to NuGet and then hopefully a stable version shortly afterwards. |
|
Hi @mattleibow . I think I posted our update elsewhere but just saw this. We have tested the preview build and it works as expected. A stable build with this fix would be much appreciated! Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR just removes the code that prevents OpenGL from working on Windows ARM.
This was initially done in mono/skia@0c75727. The reason for this was there was no OpenGL on ARM. However, recently, there is a way: https://apps.microsoft.com/detail/9nqpsl29bfff
The reason we can just remove this code is because we don't actually link with opengl32 directly and instead load it at runtime.
Bugs Fixed
API Changes
None.
Behavioral Changes
None.
Required skia PR
None.
PR Checklist