Make two DrawText methods obsolete because of #3122#3165
Open
pauldendulk wants to merge 3 commits into
Open
Conversation
5 tasks
mattleibow
added a commit
that referenced
this pull request
Jun 9, 2026
Promote SKPaint text/font obsolete members to error (#4068) Fixes: #3732 Phase 1 of the SKPaint text-API removal plan. Promotes ~115 warning-level [Obsolete] attributes on SKPaint text/font members to [Obsolete(..., error: true)], so the existing RemoveObsoleteSymbols build task strips them from the reference assembly. Also promotes: * 5 paint-only DrawText/DrawTextOnPath overloads on SKCanvas * 2 DrawText(text, x/point, font, paint) overloads from PR #3165 * 11 SKFilterQuality-consuming overloads across SKBitmap, SKImage, SKShader, and SKPixmap Internal callers that still need access to legacy paint state (DrawImage, DrawAtlas, DrawText, HarfBuzz shaper) use four new non-obsolete bypass helpers: GetLegacyFont(), GetLegacyTextAlign(), GetLegacyTextEncoding(), and GetLegacyFilterQualitySampling(). These are internal-only, exposed via InternalsVisibleTo. No runtime behavior change for downstream consumers. Obsolete SKPaint text-API tests removed from SKPaintTest.cs—they cannot compile against the ref assembly (CS1061, not CS0619). Equivalent coverage exists in SKFontTest.cs for MeasureText, BreakText, CountGlyphs, GetGlyphs, ContainsGlyphs, GetGlyphWidths, and GetTextPath. Gallery samples and SkiaFiddle migrated to pass SKTextAlign.Left explicitly instead of relying on paint.TextAlign default state. Co-authored-by: Ramez Gerges <ramezragaa@proton.me> Co-authored-by: Ramez Ragaa <66218781+ramezgerges@users.noreply.github.com> Co-authored-by: Matthew Leibowitz <mattleibow@live.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Made two DrawText methods obsolete that use the obsolete SKPaint.TextAlign, which caused a text to disappeared after drawing the same text multiple times. Two other DrawText methods were already obsolete, seemingly also because of the obsolete SKPaint.TextAlign.
Bugs Fixed
API Changes
Users will get a warning (or error if WarningAsError is true) when calling these methods.
Made obsolete:
public void DrawText (string text, SKPoint p, SKFont font, SKPaint paint)public void DrawText (string text, SKPoint p, SKTextAlign textAlign, SKFont font, SKPaint paint)Behavioral Changes
None.
Required skia PR
None.
PR Checklist
Perhaps documentation needs to be updated, not sure what or how.