fix: XamlRoot may be null when the SKXamlCanvas is unloaded #2854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mattleibow could it be possible to backport this one to 2.88? Thanks! |
jdobelstein
reviewed
May 16, 2024
There was a problem hiding this comment.
jeromelaban is a null check in on the root.Invalidate call needed for the same reason? Couldn't hurt.
That's fair. I ignored that particular site because the |
mattleibow
approved these changes
Jun 3, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jun 3, 2024
* fix: XamlRoot may be null when the SKXamlCanvas is unloaded * chore: Adjust more xamlroot uses --------- Co-authored-by: Matthew Leibowitz <[email protected]> (cherry picked from commit 8e7a51d)
mattleibow
pushed a commit
that referenced
this pull request
Jun 18, 2024
…2884) * fix: XamlRoot may be null when the SKXamlCanvas is unloaded * chore: Adjust more xamlroot uses --------- Co-authored-by: Matthew Leibowitz <[email protected]> (cherry picked from commit 8e7a51d) Co-authored-by: Jérôme Laban <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Avoids an NRE when using a null
XamlRooton WinUI when the control is unloading.API Changes
None.
Behavioral Changes
None.
Required skia PR
None.