Skip to content

Making the Forms views more extendable #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattleibow merged 8 commits into from
Apr 23, 2017
Merged

Making the Forms views more extendable #269

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
763427c
A few adjustments to head towards resolving issue #260
mattleibow Mar 22, 2017
b5d20f8
The other solutions
mattleibow Mar 22, 2017
05f2fb2
Use the older build tools for mono
mattleibow Mar 22, 2017
cb447a1
Android uses a renderer, not events
mattleibow Mar 22, 2017
bf85c63
Merge branch 'master' into forms-changes
mattleibow Mar 23, 2017
ccfb347
Merge branch 'master' into forms-changes
mattleibow Mar 24, 2017
562cf20
Merge branch 'master' into forms-changes
mattleibow Apr 23, 2017
1c30427
newline character at the end of the file
mattleibow Apr 23, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions source/SkiaSharp.Views.Forms/SkiaSharp.Views.Forms.Native.Shared/SKGLViewRendererBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,11 @@ protected override void OnElementChanged(ElementChangedEventArgs<TFormsView> e)
if (Control != null)
{
var control = Control;
#if __ANDROID__
control.SetRenderer(null);
#else
control.PaintSurface -= OnPaintSurface;
#endif
}

if (e.NewElement != null)
Expand All @@ -47,7 +51,11 @@ protected override void OnElementChanged(ElementChangedEventArgs<TFormsView> e)

// create the native view
var view = CreateNativeControl();
#if __ANDROID__
view.SetRenderer(new Renderer(newController));
#else
view.PaintSurface += OnPaintSurface;
#endif
SetNativeControl(view);

// subscribe to events from the user
Expand Down Expand Up @@ -96,7 +104,11 @@ protected override void Dispose(bool disposing)
var control = Control;
if (control != null)
{
#if __ANDROID__
control.SetRenderer(null);
#else
control.PaintSurface -= OnPaintSurface;
#endif
}

base.Dispose(disposing);
Expand Down Expand Up @@ -127,5 +139,22 @@ private void OnPaintSurface(object sender, SKNativePaintGLSurfaceEventArgs e)
// the control is being repainted, let the user know
controller?.OnPaintSurface(new SKPaintGLSurfaceEventArgs(e.Surface, e.RenderTarget));
}

#if __ANDROID__
private class Renderer : SKNativeView.ISKRenderer
{
private readonly ISKGLViewController controller;

public Renderer(ISKGLViewController controller)
{
this.controller = controller;
}

public void OnDrawFrame(SKSurface surface, GRBackendRenderTargetDesc renderTarget)
{
controller.OnPaintSurface(new SKPaintGLSurfaceEventArgs(surface, renderTarget));
}
}
#endif

@gentledepp gentledepp Mar 23, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need this renderer construct? Is there a problem with the PaintSurface subscriptions? (just curious)

@mattleibow mattleibow Mar 23, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The types are different. The incoming event is a native type in the SkiaSharp.Views.PLATFORM assembly, and I am constructing a SkiaSharp.Views.Forms assembly type. It is the programmer within that couldn't think of different names :)

@gentledepp gentledepp Mar 23, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh ok 👍

@mattleibow mattleibow Mar 23, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No wait. My bad.

The Android GL view does not use events. It is the surface-based system, which separates the view from the actual rendering via this render construct.

@mattleibow mattleibow Mar 23, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pattern can be seen in the docs: https://developer.android.com/reference/android/opengl/GLSurfaceView.html

}
}