Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start using spans instead of arrays #2617

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Start using spans instead of arrays #2617

wants to merge 2 commits into from

Conversation

mattleibow
Copy link
Contributor

@mattleibow mattleibow commented Sep 18, 2023 •
edited
Loading

Description of Change

This PR is just starting the migration to spans over arrays. Arrays require GC and spans can be arrays. So, a win-win!

Bugs Fixed

API Changes

Removing the explicit array methods and adding spans where there is none.

  • SKData
  • SKImage
  • SKPathEffect
  • SKRoundRect

Behavioral Changes

None.

Required skia PR

None.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Merged related skia PRs
  • Changes adhere to coding standard
  • Updated documentation

@mattleibow mattleibow mentioned this pull request Sep 18, 2023
Open
35 tasks
@mattleibow mattleibow enabled auto-merge (squash) September 18, 2023 20:20
@DJGosnell DJGosnell mentioned this pull request Sep 3, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] SetRectRadii overloads with pointer/span
1 participant
@mattleibow