Skip to content

feat(wasm): Add mt and mt+simd, fix harfbuzz for emsdk 3.1.12 - #2286

Merged
mattleibow merged 9 commits into
mono:mainfrom
unoplatform:dev/jela/wasm-mt-simd
Oct 20, 2022
Merged

feat(wasm): Add mt and mt+simd, fix harfbuzz for emsdk 3.1.12#2286
mattleibow merged 9 commits into
mono:mainfrom
unoplatform:dev/jela/wasm-mt-simd

Conversation

@jeromelaban

@jeromelaban jeromelaban commented Oct 12, 2022

Copy link
Copy Markdown
Contributor

Description of Change

Adds explicit support for multi-threaded and SIMD combinations.

Bugs Fixed

API Changes

None.

Behavioral Changes

None.

Required skia PR

None.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Merged related skia PRs
  • Changes adhere to coding standard
  • Updated documentation

mattleibow
mattleibow previously approved these changes Oct 12, 2022
@mattleibow

Copy link
Copy Markdown
Contributor

Do all these changes affect both libSkiaSharp and libHarfBuzzSharp?

I can't recall if this did both.

@jeromelaban

Copy link
Copy Markdown
Contributor Author

It looks like it does not, I'll make the change there as well.

@jeromelaban
jeromelaban marked this pull request as draft October 12, 2022 12:59
@mattleibow

Copy link
Copy Markdown
Contributor

In a separate PR I'll try get wasm tests to run in all these combos.

@jeromelaban jeromelaban changed the title feat(wasm): Add mt and mt+simd for emsdk 3.1.12 feat(wasm): Add mt and mt+simd, fix harfbuzz for emsdk 3.1.12 Oct 12, 2022
@jeromelaban
jeromelaban force-pushed the dev/jela/wasm-mt-simd branch from 54efc28 to 8784f17 Compare October 12, 2022 13:31
@jeromelaban
jeromelaban force-pushed the dev/jela/wasm-mt-simd branch from cba3d79 to 8abdd5f Compare October 12, 2022 17:19
@jeromelaban
jeromelaban force-pushed the dev/jela/wasm-mt-simd branch from 8abdd5f to 7d7e475 Compare October 12, 2022 17:45
@jeromelaban
jeromelaban marked this pull request as ready for review October 13, 2022 12:26
@VahidN

VahidN commented Dec 28, 2022

Copy link
Copy Markdown

Sorry to ask it here. Are you using the last harfbuzz (V 6x)?

@drdmohssine

Copy link
Copy Markdown

I'm still getting the error:
--shared-memory is disallowed by libskia.SkOpts.o because it was not compiled with 'atomics' or 'bulk-memory' features.
is there any fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants