Move Skottie and SceneGraph out of the core SkiaSharp.dll#2091
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
2 similar comments
This comment was marked as outdated.
This comment was marked as outdated.
|
Azure Pipelines successfully started running 1 pipeline(s). |
jeromelaban
previously approved these changes
Jun 1, 2022
commit a699d1ec3e3a5a6cbfffccb8c345da9b8235d5fe
Author: Matthew Leibowitz <mattleibow@live.com>
Date: Wed Jun 1 18:23:18 2022 +0200
revert skottie stuff
commit 9e8c4da
Author: Matthew Leibowitz <mattleibow@live.com>
Date: Wed Jun 1 18:18:46 2022 +0200
Merge the classic projects
commit db98562
Author: Matthew Leibowitz <mattleibow@live.com>
Date: Wed Jun 1 16:56:07 2022 +0200
build classic
commit 5129e2b
Author: Matthew Leibowitz <mattleibow@live.com>
Date: Wed Jun 1 10:31:10 2022 +0200
make iOS happy
commit 85fa204
Author: Matthew Leibowitz <mattleibow@live.com>
Date: Wed Jun 1 09:51:09 2022 +0200
sln
commit ecd1a45
Author: Matthew Leibowitz <mattleibow@live.com>
Date: Wed Jun 1 01:57:30 2022 +0200
that too
commit eb5449f
Author: Matthew Leibowitz <mattleibow@live.com>
Date: Wed Jun 1 01:45:34 2022 +0200
nuspec
commit 4330c93
Author: Matthew Leibowitz <mattleibow@live.com>
Date: Wed Jun 1 01:38:30 2022 +0200
The tests
commit 42154a8
Author: Matthew Leibowitz <mattleibow@live.com>
Date: Wed Jun 1 01:24:00 2022 +0200
ws
commit 44ea2aa
Author: Matthew Leibowitz <mattleibow@live.com>
Date: Wed Jun 1 01:22:52 2022 +0200
Move Skottie into a new package
# Conflicts: # source/SkiaSharpSource.Mac.slnf # source/SkiaSharpSource.Windows-netfx.slnf # source/SkiaSharpSource.Windows.slnf # source/SkiaSharpSource.sln
Collaborator
Author
|
/azp run SkiaSharp |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mattleibow
marked this pull request as ready for review
June 3, 2022 02:53
Collaborator
Author
|
/azp run SkiaSharp |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
/azp run SkiaSharp |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
/azp run SkiaSharp |
1 similar comment
Collaborator
Author
|
/azp run SkiaSharp |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
No functional changes, just moving the types.
The reason for this is so that if anything happens to Scene Graph or Skottie, we don't have any issues. I am not 100% sure of the reason behind these modules and how they relate to Chromium.
Also, I do want to investigate in the future a way to compile skia and not have a single blob of bits and rather split this up into separate native binaries - if possible.
Bugs Fixed
None.
API Changes
None.
Behavioral Changes
None.
Required skia PR
None.
PR Checklist