feat: Add basic Skottie support#1987
Merged
Merged
Conversation
jeromelaban
force-pushed
the
dev/jela/skottie
branch
from
March 31, 2022 18:58
f8a852a to
f419077
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jeromelaban
force-pushed
the
dev/jela/skottie
branch
from
April 4, 2022 12:03
14593bb to
9f5a343
Compare
jeromelaban
marked this pull request as ready for review
April 4, 2022 12:32
Contributor
Author
|
Uno 4.1.9 is binary compatible with .NET 6 Mobile RC1, so given that RC1 is used by the repository, the build should be now fine. |
jeromelaban
force-pushed
the
dev/jela/skottie
branch
from
May 28, 2022 00:51
9f5a343 to
0329c71
Compare
mattleibow
reviewed
May 28, 2022
mattleibow
left a comment
mattleibow
left a comment
Collaborator
There was a problem hiding this comment.
Mostly hidden interfaces and naming in a pool of bad names...
Otherwise, this is a nice addition!
| } | ||
|
|
||
| // SK_C_API skottie_animation_t* skottie_animation_make_from_string(const char* data, size_t length); | ||
| public static Animation Make (string data) |
Collaborator
There was a problem hiding this comment.
To .NET-ify, this should be Parse and to fully make it nice, should we add a TryParse?
Contributor
Author
There was a problem hiding this comment.
I've changed all of them to TryCreate or TryParse. The native implementation returns null when the parsing failed, so the only .NET semantic that makes sense here would be a TryParse, or Parse with a nullable return (which is not current available in this solution).
mattleibow
reviewed
May 28, 2022
jeromelaban
marked this pull request as draft
May 29, 2022 00:24
jeromelaban
force-pushed
the
dev/jela/skottie
branch
from
May 29, 2022 01:38
2073e9c to
038c5b6
Compare
jeromelaban
marked this pull request as ready for review
May 29, 2022 13:08
jeromelaban
force-pushed
the
dev/jela/skottie
branch
from
May 30, 2022 12:56
b28d59f to
21e285d
Compare
jeromelaban
marked this pull request as draft
May 30, 2022 13:04
Contributor
Author
|
I added 21e285d to validate that the build passes fully, will remove once it does. |
jeromelaban
force-pushed
the
dev/jela/skottie
branch
2 times, most recently
from
May 30, 2022 15:25
305d14e to
b6d7822
Compare
jeromelaban
marked this pull request as ready for review
May 30, 2022 15:29
jeromelaban
force-pushed
the
dev/jela/skottie
branch
from
May 30, 2022 20:36
e084cd2 to
db53a08
Compare
mattleibow
previously approved these changes
May 30, 2022
mattleibow
previously approved these changes
May 31, 2022
jeromelaban
force-pushed
the
dev/jela/skottie
branch
2 times, most recently
from
May 31, 2022 13:14
7ccaa61 to
1178a72
Compare
jeromelaban
force-pushed
the
dev/jela/skottie
branch
from
May 31, 2022 13:29
1178a72 to
caf00c1
Compare
mattleibow
added
type/enhancement
area/SkiaSharp
|
How would we specify the Assets folder for png files? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Adds basic support for Skottie (dependent on mono/skia#84)
Related to issue #1580 #661
Size changes:
Bugs Fixed
Fixes #661
API Changes
Added:
SkiaSharp.Skottie.AnimationSkiaSharp.Skottie.InvlidationControllerRequired skia PR
mono/skia#84
PR Checklist