Fix the Mac Catalyst build task Inputs/Outputs - #1865
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR correctly handles the incremental builds of the mac catalyst targets. Previously, the entire task was skipped if the stamp file existed.
However, if for some reason the native file in the bin folder was deleted, then the task never ran again. This is because technically the target was ready, we just need to re-create the items. So to do this we set the targets file as the import and the stamp as the output. Then, MSBuild will do its thing and ensure that no tasks run, just the properties and items are set.
Bugs Fixed
API Changes
Behavioral Changes
PR Checklist