Skip to content

IsAntialias should also control the Edging - #1802

Merged
mattleibow merged 1 commit into
patch/v2.80.4from
dev/aa
Sep 8, 2021
Merged

IsAntialias should also control the Edging#1802
mattleibow merged 1 commit into
patch/v2.80.4from
dev/aa

Conversation

@mattleibow

@mattleibow mattleibow commented Sep 8, 2021

Copy link
Copy Markdown
Contributor

Description of Change

@mattleibow

This is for compatibility and consistency. Before 2.80, the anti-aliasing flag would also affect the font edging. After 2.80, the properties were separate and now we have to make sure the paint updates the edging based on what the anti-aliasing and LCD rendering indicate.

Bugs Fixed

1.68.x 2.80.x PR
image image image
cnv.Clear(SKColors.White);

var paint = new SKPaint();
paint.TextSize = 40;

paint.IsAntialias = false;
paint.LcdRenderText = false;
cnv.DrawText("Hello World!", 20, 50, paint);

paint.IsAntialias = true;
paint.LcdRenderText = false;
cnv.DrawText("Hello World!", 20, 100, paint);

paint.IsAntialias = false;
paint.LcdRenderText = true;
cnv.DrawText("Hello World!", 20, 150, paint);

paint.IsAntialias = true;
paint.LcdRenderText = true;
cnv.DrawText("Hello World!", 20, 200, paint);

API Changes

Behavioral Changes

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Changes adhere to coding standard
  • Updated documentation

This is for compatibility and consistency. Before 2.80, the anti-aliasing flag would also affect the font edging. After 2.80, the properties were separate and now we have to make sure the paint updates the edging based on what the anti-aliasing and LCD rendering indicate.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant