Split SkiaSharp package into smaller "Native Asset" packages - #1758
Merged
Conversation
mattleibow
marked this pull request as draft
August 5, 2021 16:11
mattleibow
marked this pull request as ready for review
August 5, 2021 23:56
mattleibow
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Right now the SkiaSharp package is 120 MB and this takes forever to download, and things like .NET Interactive sometimes time out.
Previously the Page was about 30 MB and this was big, but not huge. In recent updates we have added more platforms and slowly seen the size rise. In order to add maccatalyst, we are going to push the size up even more.
So, to fix all this, the PR breaks out the platforms into chunks that get pulled in as needed. There is no need for a 30MB watchOS platform when we are building Android.
Bugs Fixed
API Changes
None.
Behavioral Changes
MSBuild code that would directly work with assets in the SkiaSharp package will no longer work. They are still in the same location, but now in a new package ID.
PR Checklist