Add support for WinUI 3 by mattleibow · Pull Request #1458 · mono/SkiaSharp

mattleibow · 2020-08-11T01:33:40Z

Description of Change

Add support for WinUI 3 views
Add WinUI 3 samples for Desktop and UWP

Bugs Fixed

Fixes [FEATURE] WinUI 3 support #1298

Known Issues

No GPU support (yet... maybe...): WinUI 3 Preview 1, ANGLE.WindowsStore and SwapChainPanel microsoft/microsoft-ui-xaml#2558

API Changes

Behavioral Changes

PR Checklist

Has tests (if omitted, state reason in description)
Rebased on top of master at time of PR
Changes adhere to coding standard
Updated documentation

michael-hawker · 2020-08-11T07:27:28Z

@@ -0,0 +1,28 @@
+<Project Sdk="Microsoft.NET.Sdk">


@azchohfi is there an easier way to multi-target this project with the 'UWP' WinUI file above?

You could just multi-target, but the whole structure for SkiaSharp is already like this for every single other target, so I believe it makes sense to keep it this way.

Oh, now I noticed what happened. @mattleibow, version 2.1.2 of MSBuild.Sdk.Extras added support for net5.0 TFMs, so you could, if you want to, merge the SkiaSharp.Views.WinUI.csproj and SkiaSharp.Views.WinUI.UWP.csproj .

Oh, yay! I'll do that. I didn't see the shiny new update!

Seems I am still getting errors on the restore, but this is MSBuild/NuGet issues because I don't think the restore process supports the conditionals. In my case, I had the WinUI project that depends on either SkiaSharp.UWP and SkiaSharp projects depending on which TFM was selected.

I need to actually do a full multi-targeting setup here. The reason I didn't before was due to VSMac having issues and VSWin not working properly - but this is most likely fixed since I started this when multi-targeting was hot off the press.

I'm going to keep it 2 projects for now, and then start some research into multi-targeting in a new PR. This time with new build tools and IDEs.

DierkDroth · 2020-10-22T06:55:10Z

@mattleibow I was educated by my team that this issue prevents switching our Platform UNO solution to WinUI 3 (we're using SkiaSharp rendering massively).

Is there any ETA yet?

@jeromelaban FYI

jeromelaban · 2020-10-22T11:38:47Z

@DierkDroth thanks. As mentioned in the Uno issue, WinUI 3.0 is not required yet. WinUI 2.x can be used at this point.

DierkDroth · 2020-10-22T14:36:17Z

@jeromelaban sorry, I'm still lost.

Let me ask you this: how would a WinUI 3 TabView host a SkiaSharp chart?

jeromelaban · 2020-10-23T11:41:01Z

@jeromelaban sorry, I'm still lost.

Let me ask you this: how would a WinUI 3 TabView host a SkiaSharp chart?

The TabView control is available in WinUI 2.x and is available starting in Uno 3.1, there is no need for WinUI 3.0 at this point.

DierkDroth · 2020-10-24T11:27:36Z

Thanks @jeromelaban. This seems to be a viable work around

gmurray81 · 2020-11-06T03:36:35Z

@mattleibow might some preview of this ship soon? Have been extracting stuff from this PR to try but that seems like it would be a bit more painful for the GL surfaces.

gmurray81 · 2020-11-18T14:31:43Z

@mattleibow btw, the IBufferByteAccess binding doesn't work in WinUI preview 3, I was able to make it work again by comparing against the wincsrt codebase for IBufferByteAccess, maybe they could add an easier way to grab that interface? Or maybe they did already, didn't search too long.

rick-palmsens · 2021-01-08T16:21:47Z

@gmurray81 I seem to be running into the same error:

Invalid cast from 'WinRT.IInspectable' to 'SkiaSharp.Views.Interop.IBufferByteAccess'.

Could you tell me what you changed to make it work again?

mattleibow · 2021-02-13T02:36:35Z

I have updated a few things. The WinUI sample is running again. The implementation for Win32 is a tad bit different due to some UWP APIs not existing/implemented.

The GPU views might take longer because ANGLE does not support WinUI and there appears to be know immediate plans to add it: microsoft/microsoft-ui-xaml#2558

Once things are building, I can release a preview package on the preview feed for people to try out.

michael-hawker · 2021-02-13T06:51:33Z

🦙 Seems like the Angle work has moved to Google and their discussion was placed here. (Though still that it's not in plans, but that was 8 months ago.) FYI @stmoy

rick-palmsens · 2021-02-17T10:18:49Z

Is ANGLE necessary for the Win32 version of WinUI? In theory you should be able to call OpenGL directly when not confined to the UWP sandbox.

mnikonov · 2021-02-17T17:19:05Z

@mattleibow thanks for your work!!!! Is there is any guess when pre release package with WinUI support would be possible to download? Also question would be package with name SkiaSharp.Views.Uno.WinUI ? :)

# Conflicts: # binding/SkiaSharp/SkiaSharp.csproj # samples/Basic/WinUI/Desktop/SkiaSharpSample.Package/Package.appxmanifest # samples/Basic/WinUI/Desktop/SkiaSharpSample.Package/SkiaSharpSample.Package.wapproj # samples/Basic/WinUI/Desktop/SkiaSharpSample.sln # samples/Basic/WinUI/Desktop/SkiaSharpSample/App.xaml.cs # samples/Basic/WinUI/Desktop/SkiaSharpSample/MainWindow.xaml # samples/Basic/WinUI/Desktop/SkiaSharpSample/MainWindow.xaml.cs # samples/Basic/WinUI/Desktop/SkiaSharpSample/SkiaSharpSample.csproj # scripts/azure-pipelines.yml # scripts/azure-templates-bootstrapper.yml # source/SkiaSharp.Views.WinUI/SkiaSharp.Views.WinUI/SkiaSharp.Views.WinUI.csproj # source/SkiaSharp.Views/SkiaSharp.Views.Shared/Extensions.cs # source/SkiaSharp.Views/SkiaSharp.Views.Shared/GlesInterop/Gles.cs # source/SkiaSharp.Views/SkiaSharp.Views.UWP/AngleSwapChainPanel.cs # source/SkiaSharp.Views/SkiaSharp.Views.UWP/GlesInterop/GlesContext.cs # source/SkiaSharp.Views/SkiaSharp.Views.UWP/Interop/IBufferByteAccess.cs # source/SkiaSharp.Views/SkiaSharp.Views.UWP/Interop/PropertySetExtensions.cs # source/SkiaSharp.Views/SkiaSharp.Views.UWP/SKSwapChainPanel.cs # source/SkiaSharp.Views/SkiaSharp.Views.UWP/SKXamlCanvas.cs # source/SkiaSharp.Views/SkiaSharp.Views.UWP/UWPExtensions.cs # source/SkiaSharpSource.Windows.sln # source/SkiaSharpSource.sln

mattleibow · 2021-05-19T23:50:28Z

I pushed out a preview package (SkiaSharp.Views.WinUI) to https://aka.ms/skiasharp-eap/index.json

This is just the SKXamlCanvas for now as I try and get the ANGLE builds working with the new views.

gmurray81 · 2021-05-20T02:19:40Z

Awesome! Thanks :)

MaksimNikonovOrioninc · 2021-05-21T21:29:12Z

@mattleibow is there is any plans to have compatible version of SkiaSharp.Views.WinUI with UWP and UNO?

jeromelaban · 2021-05-22T14:09:33Z

@MaksimNikonovOrioninc yes there are plans to make this support work for the Uno.WinUI packages. I will be in a separate PR, though.

mattleibow · 2021-07-12T01:44:23Z

Closing this as we got WinUI support for Desktop/Win32 a few releases back, but now stable.

Additional things

Uno will be in a separate PR
UWP will be in a separate PR

gmurray81 · 2021-07-12T15:19:46Z

@mattleibow what about the GPU support for WinUI3? Separate task? Giving up on it due to the lack of Angle support?

Is he implying here that it should be supportable with the current stuff in Angle? https://groups.google.com/g/angleproject/c/oq7JU0StLCs/m/IoaPPVapBAAJ

mattleibow added 3 commits August 11, 2020 03:31

Add WinUI 3 views

259fe47

Add WinUI 3 Desktop sample

9f92bad

Add WinUI 3 UWP sample

20471e0

michael-hawker reviewed Aug 11, 2020

View reviewed changes

mattleibow added 6 commits August 12, 2020 14:41

Use .net core 5

ad6b2ab

.x

e872494

Update MSBuild.Sdk.Extras

9782b24

We might need both versions

e7e4ed4

:)

b8553fb

try preview before stable

65dd92f

DierkDroth mentioned this pull request Oct 22, 2020

[Wasm] ProgressBar IsIndeterminate is not working unoplatform/uno#4327

Closed

Base automatically changed from master to main February 5, 2021 08:30

mattleibow added 2 commits February 13, 2021 00:27

Merge branch 'main' into dev/winui

e196191

Got things working with WinUI 3 preview 4

238c602

mattleibow mentioned this pull request May 4, 2021

Add support for WinUI for Desktop #1696

Merged

4 tasks

robloo mentioned this pull request May 12, 2021

WinUI MapControl Replacement Mapsui/Mapsui#1125

Closed

8 tasks

mattleibow added 2 commits May 18, 2021 04:07

nuspec

b69c949

mattleibow closed this Jul 12, 2021

mattleibow deleted the dev/winui branch July 12, 2021 01:44

Uh oh!

Conversation

mattleibow commented Aug 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

michael-hawker Aug 11, 2020

Choose a reason for hiding this comment

Uh oh!

azchohfi Aug 11, 2020

Choose a reason for hiding this comment

Uh oh!

azchohfi Aug 11, 2020

Choose a reason for hiding this comment

Uh oh!

mattleibow Aug 11, 2020

Choose a reason for hiding this comment

Uh oh!

mattleibow Aug 12, 2020

Choose a reason for hiding this comment

Uh oh!

DierkDroth commented Oct 22, 2020

Uh oh!

jeromelaban commented Oct 22, 2020

Uh oh!

DierkDroth commented Oct 22, 2020

Uh oh!

jeromelaban commented Oct 23, 2020

Uh oh!

DierkDroth commented Oct 24, 2020

Uh oh!

gmurray81 commented Nov 6, 2020

Uh oh!

gmurray81 commented Nov 18, 2020

Uh oh!

rick-palmsens commented Jan 8, 2021

Uh oh!

mattleibow commented Feb 13, 2021

Uh oh!

michael-hawker commented Feb 13, 2021

Uh oh!

rick-palmsens commented Feb 17, 2021

Uh oh!

mnikonov commented Feb 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mattleibow commented May 19, 2021

Uh oh!

gmurray81 commented May 20, 2021

Uh oh!

MaksimNikonovOrioninc commented May 21, 2021

Uh oh!

jeromelaban commented May 22, 2021

Uh oh!

mattleibow commented Jul 12, 2021

Uh oh!

gmurray81 commented Jul 12, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

mattleibow commented Aug 11, 2020 •

edited

Loading

mnikonov commented Feb 17, 2021 •

edited

Loading