docs(openspec): retro-audit 8 個 archived changes 未完成 tasks(newer-wins) - #83
Conversation
… conflict resolution) 掃描所有 archived OpenSpec changes 後找到 8 個 archive 帶未完成 tasks,依 CLAUDE.md §2 newer-wins conflict resolution 規則逐項標註: - 2026-05-21-recap (23/24):實作 PR #79 已 merged,retro-tick `[x]` + 引 evidence - 2026-05-21-coordinator-ifc-ready-worker-webhook (26/26):documentation lag 確認 — newer spec authority 已存在於 `openspec/specs/{local-coordinator- ifc-ready-intake-boundary,review-session-request-lifecycle,conversion- webhook-lifecycle}/spec.md` 但 code 未實作;標 `— deferred: spec authority exists, implementation follow-up required`,後續若要落地需新開 change - 2026-05-18-local-coordinator-ifc-ready-intake-boundary §10.5:post-merge gate,PR #63 merge 後 PR #64 已完成 sync/archive,retro-tick - 2026-05-18-introduce-ai-bim-runtime-manager-docker-kit-mvp:Linux Kit launcher 驗證標 `blocked` + 引 WSL graphics ceiling memory - 2026-05-15-queue-batch-dispatch / -optimize-worker-canonical-batch / 2026-05-12-worker-canonical-storage-batch-baseline / 2026-05-07-add-dev- ifc-source-selection-flow:全部 `_worker` 範圍任務標 **superseded**(_worker 已從 product runtime 刪除,CLAUDE.md §2) Conflict resolution 規則: - `[x]` = 實作已落地(cite PR / file path) - `[ ] — superseded` = newer spec / B 方案邊界吃掉舊 task - `[ ] — deferred` = newer spec authority 存在但 code 未實作(追蹤用) - `[ ] — blocked` = hardware / WSL graphics 阻擋,保留既有標記 Verification: - openspec validate --specs --strict ✓ 25 passed / 0 failed - 純文件改動,零 production source 改動 - 不新增 dependency - archive folder 是 read-only artifact 但允許 retro-audit 標註 Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (8)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
這個 PR 針對 openspec/changes/archive/ 內已歸檔的 OpenSpec changes 做 retro-audit:把原本 archive 時留下的未完成 tasks,依 CLAUDE.md §2 的 newer-wins 規則回填為 [x](已有實作/文件證據)或標註為 superseded / deferred / blocked(誠實追蹤 spec drift、範圍退役或環境阻擋),確保 archive 作為「read-only artifact」時仍能反映現況。
Changes:
- 回填
2026-05-21-recap等 archive 的 tasks checklist,補上 evidence(runbook/roadmap/spec validate 等)並 retro-tick 已完成項目。 - 將
coordinator-ifc-ready-worker-webhookarchive tasks 明確標註為deferred(spec authority 已存在但 code 未落地)以追蹤 spec drift。 - 對多個
_worker範圍的 archive tasks 統一標註為superseded(B-scheme runtime 已退役_worker路徑),以及對 Kit/WSL 阻擋項標註blocked。
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| openspec/changes/archive/2026-05-21-recap/tasks.md | retro-audit 回填 runbook/roadmap/spec/verification/PR/archive tasks 狀態與 evidence |
| openspec/changes/archive/2026-05-21-coordinator-ifc-ready-worker-webhook/tasks.md | 將 tasks 統一標註為 deferred(spec authority 存在但實作缺口仍在)並補引用 |
| openspec/changes/archive/2026-05-18-local-coordinator-ifc-ready-intake-boundary/tasks.md | retro-tick post-merge gate 10.5,補 PR #63/#64 溯源說明 |
| openspec/changes/archive/2026-05-18-introduce-ai-bim-runtime-manager-docker-kit-mvp/tasks.md | 將 Linux Kit launcher runtime 驗證標註為 blocked,補 retro-audit 說明 |
| openspec/changes/archive/2026-05-15-queue-batch-dispatch-and-post-usdc-artifact-retention/tasks.md | 將 canonical batch 真實 evidence/footprint tasks 標註為 superseded(_worker 退役) |
| openspec/changes/archive/2026-05-15-optimize-worker-canonical-batch-and-secondary-enumeration/tasks.md | 在 archive tasks 加 retro-audit header,並把 _worker 範圍未完成項標 superseded |
| openspec/changes/archive/2026-05-12-worker-canonical-storage-batch-baseline/tasks.md | 在 archive tasks 加 retro-audit header,並把 _worker 範圍未完成項標 superseded |
| openspec/changes/archive/2026-05-07-add-dev-ifc-source-selection-flow/tasks.md | 在 archive tasks 加 retro-audit header,並把 worker UI/worker-hosted USDC 等任務標 superseded |
Comments suppressed due to low confidence (3)
openspec/changes/archive/2026-05-21-coordinator-ifc-ready-worker-webhook/tasks.md:48
- 這行用
memory kit-gpu-render-needs-windows-native/WSL-ubuntu-24-04-container-toolkit-setup當作阻擋依據,但 repo 內沒有對應的文件可供追溯(搜尋僅命中少數 archive/tasks)。建議改引用 repo 內的權威來源(例如openspec/specs/runtime-image-linux-kit-launcher-readiness/spec.md的 deferred/blocked 說明或 runbook 段落),或把 blocker 原因寫成可自洽的文字敘述。
- [ ] 5.7 在 verification evidence 明確分層:control-plane 自動接線 tier 與 `single_kit_render` / WebRTC `49100` / browser visual tier 獨立判定、不升等;後者若無 Kit build/GPU 證據標 `not_observed`,不標 passed。 — **deferred**: 依賴 4.x;Kit/WebRTC tier 受 memory `kit-gpu-render-needs-windows-native` + `WSL-ubuntu-24-04-container-toolkit-setup` 阻擋
openspec/changes/archive/2026-05-07-add-dev-ifc-source-selection-flow/tasks.md:68
- 此處同時引用 runbook 與多個
memory ...名稱作為結論依據,但 repo 內沒有對應的 memory 文件可供 reviewer 追溯。建議保留可驗證的 repo 內引用(例如 recap runbook §6 或 OpenSpec spec/capability),並移除/替換 memory 名稱,讓 superseded 判斷可在純 repo 內容下自洽。
- [ ] 7.6 Browser-validate worker UI on `http://127.0.0.1:8005/` for IFC listing, selected conversion trigger, polling, and readiness handoff. — **superseded** (Retro-audited 2026-05-21): worker UI 退役;現行 demo intake 改走 `bim-review-coordinator` `POST /api/external/ifc-ready` + smoke script,UI listing/selection 由 viewer 取代。
- [ ] 7.7 If GPU/Kit is available, validate the review viewer still opens a worker-hosted USDC URL; otherwise record Kit/WebRTC as hardware-dependent. — **superseded** (Retro-audited 2026-05-21): worker-hosted USDC URL 退役;現行 USDC 由 streaming-server 權威。Kit/WebRTC hardware-dependent 結論在 recap runbook §6 與 memory `kit-gpu-render-needs-windows-native` / `WSL-ubuntu-24-04-container-toolkit-setup` 已凍結。
openspec/changes/archive/2026-05-21-recap/tasks.md:49
— PR #79 commit msg 三項皆涵蓋這行同樣是縮排文本但缺少 list marker,GitHub Markdown 可能會把它渲染成 code block 而不是清單說明。建議改成 nested bullet/paragraph continuation(例如加-或調整縮排),避免在 archive tasks 中產生不可預期的排版。
- [x] 5.3 PR body 標註:
- predecessor `coordinator-ifc-ready-worker-webhook` archive 未落地的提醒
- GitNexus blast radius = LOW(純 docs,零 production symbol 改動)
- 本 change 不新增 production dependency
— PR #79 commit msg 三項皆涵蓋
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…ready auto-session(spec drift 收斂) 補 archive 2026-05-21-coordinator-ifc-ready-worker-webhook 的 documentation lag(retro-audit commit a32fcd6 確認 spec 已 ratified、code 從未實作)。 實作(bim-review-coordinator/src/app.ts): - normalizeIntakePayload helper:external IFC-ready intake 支援 worker compatibility payload(status="ifc_ready" / ifc_path / project_id / version / task_id),正規化為 canonical ExternalIfcReadyEvent,不洩漏 進 streaming internal contract。worker compat 缺 X-Correlation-Id / X-Idempotency-Key 時從 worker:project_id::version::task_id 派生, explicit headers 仍優先(D11)。 - autoCreateOrActivateSession helper:ingestConversionReport terminal ready 分支於 callbackOutbox.enqueue 之後並行呼叫,重用既有 SessionStore.create + allocateKitInstanceBindings + chooseReadyUsdc 邏輯,對 job.review_session_id idempotent,重入回既有 session; terminal failed 不建可串流 session;GPU/Kit 無容量回 queued_for_instance 不丟 review intent。 - ExternalIfcReadyStore.recordReviewSession() 反向綁定 + IfcReadyIntakeJob review_session_id optional 欄位(additive)。 - /api/internal/conversion-result + /api/internal/conversions/:id/ingest response 加 session / session_replay / session_reason 欄位(additive)。 11 個 spec scenarios coverage(intake 4 + auto-session 4 + webhook seam 3) 皆對應 TDD-driven test:external-ifc-ready.test.ts 新增 7 cases、 host-native-conversion-ingest.test.ts 新增 6 cases。 Spec delta:採 Option B(NO-OP-ish MODIFIED re-affirm),三份 capability (local-coordinator-ifc-ready-intake-boundary / review-session-request- lifecycle / conversion-webhook-lifecycle)各加一段 "Implementation status (2026-05-21)" backfill note,scenarios 全保留不變、語意無變動。 Verification: - coordinator npm run verify: 11 files / 165 tests passed; tsc clean - root contracts pytest: 7 passed - openspec validate backfill-coordinator-webhook-and-auto-session --strict: valid - git diff --check: clean - Affected symbols 符合 §0.2 預期,無範圍擴張(fallback git diff --stat) - Render tier (single_kit_render / WebRTC 49100 / browser visual): not_observed (Kit build + GPU host 前置;memory kit-gpu-render-needs-windows-native) - OQ1 (雲端 callback endpoint/auth) / OQ5 (SSO) 仍 pending Evidence: - docs/verification/2026-05-21-backfill-coordinator-webhook-and-auto-session.md - roadmap md + html 同步更新(2026-05-21 backfill apply 通告) 不解 / 不升等: - 不修改 archive 2026-05-21-coordinator-ifc-ready-worker-webhook/tasks.md upgrade(依賴 retro-audit PR #83 先 merge,post-merge gate) - 不啟動 / 控制 Kit 進程、不開 USD stage、不渲染 - 不新增 production dependency Predecessor: 2026-05-21-coordinator-ifc-ready-worker-webhook (archive, documentation lag) Related: PR #83 retro-audit, PR #84 propose (this change) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…ted (post-PR #83 merge) retro-audit PR #83 commit e8e576d 已合進 main,archive 2026-05-21-coordinator-ifc-ready-worker-webhook/tasks.md 的 26 個 deferred 標記源自該 commit。本 branch rebase onto latest main 後做 §5.3 post-merge gate 收尾。 改動: - openspec/changes/archive/2026-05-21-coordinator-ifc-ready-worker-webhook/tasks.md: 26 個 [ ] — **deferred** 升級為 [x] — **implemented** by PR #85 (was: **deferred**: ...),原 retro-audit annotation 完整保留作為 documentation lag 證據;archive 開頭加 closeout 區塊指向 PR #85 evidence。 - openspec/changes/backfill-coordinator-webhook-and-auto-session/tasks.md: §5.3 自身狀態升 [x]。 Verification: - openspec validate backfill-coordinator-webhook-and-auto-session --strict: valid - 純文件改動,零 code 改動 Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…ready auto-session(implement spec drift) (#85) * feat(coordinator): backfill worker compatibility intake + conversion-ready auto-session(spec drift 收斂) 補 archive 2026-05-21-coordinator-ifc-ready-worker-webhook 的 documentation lag(retro-audit commit a32fcd6 確認 spec 已 ratified、code 從未實作)。 實作(bim-review-coordinator/src/app.ts): - normalizeIntakePayload helper:external IFC-ready intake 支援 worker compatibility payload(status="ifc_ready" / ifc_path / project_id / version / task_id),正規化為 canonical ExternalIfcReadyEvent,不洩漏 進 streaming internal contract。worker compat 缺 X-Correlation-Id / X-Idempotency-Key 時從 worker:project_id::version::task_id 派生, explicit headers 仍優先(D11)。 - autoCreateOrActivateSession helper:ingestConversionReport terminal ready 分支於 callbackOutbox.enqueue 之後並行呼叫,重用既有 SessionStore.create + allocateKitInstanceBindings + chooseReadyUsdc 邏輯,對 job.review_session_id idempotent,重入回既有 session; terminal failed 不建可串流 session;GPU/Kit 無容量回 queued_for_instance 不丟 review intent。 - ExternalIfcReadyStore.recordReviewSession() 反向綁定 + IfcReadyIntakeJob review_session_id optional 欄位(additive)。 - /api/internal/conversion-result + /api/internal/conversions/:id/ingest response 加 session / session_replay / session_reason 欄位(additive)。 11 個 spec scenarios coverage(intake 4 + auto-session 4 + webhook seam 3) 皆對應 TDD-driven test:external-ifc-ready.test.ts 新增 7 cases、 host-native-conversion-ingest.test.ts 新增 6 cases。 Spec delta:採 Option B(NO-OP-ish MODIFIED re-affirm),三份 capability (local-coordinator-ifc-ready-intake-boundary / review-session-request- lifecycle / conversion-webhook-lifecycle)各加一段 "Implementation status (2026-05-21)" backfill note,scenarios 全保留不變、語意無變動。 Verification: - coordinator npm run verify: 11 files / 165 tests passed; tsc clean - root contracts pytest: 7 passed - openspec validate backfill-coordinator-webhook-and-auto-session --strict: valid - git diff --check: clean - Affected symbols 符合 §0.2 預期,無範圍擴張(fallback git diff --stat) - Render tier (single_kit_render / WebRTC 49100 / browser visual): not_observed (Kit build + GPU host 前置;memory kit-gpu-render-needs-windows-native) - OQ1 (雲端 callback endpoint/auth) / OQ5 (SSO) 仍 pending Evidence: - docs/verification/2026-05-21-backfill-coordinator-webhook-and-auto-session.md - roadmap md + html 同步更新(2026-05-21 backfill apply 通告) 不解 / 不升等: - 不修改 archive 2026-05-21-coordinator-ifc-ready-worker-webhook/tasks.md upgrade(依賴 retro-audit PR #83 先 merge,post-merge gate) - 不啟動 / 控制 Kit 進程、不開 USD stage、不渲染 - 不新增 production dependency Predecessor: 2026-05-21-coordinator-ifc-ready-worker-webhook (archive, documentation lag) Related: PR #83 retro-audit, PR #84 propose (this change) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(openspec): closeout — upgrade archive deferred tasks to implemented (post-PR #83 merge) retro-audit PR #83 commit e8e576d 已合進 main,archive 2026-05-21-coordinator-ifc-ready-worker-webhook/tasks.md 的 26 個 deferred 標記源自該 commit。本 branch rebase onto latest main 後做 §5.3 post-merge gate 收尾。 改動: - openspec/changes/archive/2026-05-21-coordinator-ifc-ready-worker-webhook/tasks.md: 26 個 [ ] — **deferred** 升級為 [x] — **implemented** by PR #85 (was: **deferred**: ...),原 retro-audit annotation 完整保留作為 documentation lag 證據;archive 開頭加 closeout 區塊指向 PR #85 evidence。 - openspec/changes/backfill-coordinator-webhook-and-auto-session/tasks.md: §5.3 自身狀態升 [x]。 Verification: - openspec validate backfill-coordinator-webhook-and-auto-session --strict: valid - 純文件改動,零 code 改動 Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Summary
掃描所有 archived OpenSpec changes 後找到 8 個 archive 帶未完成 tasks,依
CLAUDE.md§2 newer-wins conflict resolution 規則逐項標註。純 documentation 改動,零 production source / dependency 改動。2026-05-21-recap[x](PR #79 已落地,逐項引 evidence)2026-05-21-coordinator-ifc-ready-worker-webhookopenspec/specs/但 code 未實作2026-05-18-local-coordinator-ifc-ready-intake-boundary2026-05-18-introduce-ai-bim-runtime-manager-docker-kit-mvp2026-05-15-queue-batch-dispatch_worker範圍標 superseded2026-05-15-optimize-worker-canonical-batch_worker範圍標 superseded2026-05-12-worker-canonical-storage-batch-baseline_worker範圍標 superseded2026-05-07-add-dev-ifc-source-selection-flow_workerUI / Kit / GitNexus 標 superseded / blockedConflict resolution 規則
[x]— 實作已落地(cite PR / file path)[ ] — superseded— newer spec / B 方案邊界吃掉舊 task[ ] — deferred— newer spec authority 存在但 code 未實作(追蹤用,留 follow-up change)[ ] — blocked— hardware / WSL graphics 阻擋,保留既有標記重要發現
2026-05-21-coordinator-ifc-ready-worker-webhook是 真正的 spec drift:openspec/specs/{local-coordinator-ifc-ready-intake-boundary, review-session-request-lifecycle, conversion-webhook-lifecycle}/spec.md)已 ratified 11 個 scenarios(worker compatibility intake + conversion-ready 自動建 session + outbox/session 並行 seam)bim-review-coordinator/src/app.ts:566-628的ingestConversionReport)只走 callback outbox,未呼叫SessionStore.create;intake schema 也未支援 worker compatibility payloaddeferred而非superseded或[x],誠實追蹤Follow-up change:backfill-coordinator-webhook-and-auto-session 已另開 PR 補這個缺口。
Verification
openspec validate --specs --strict✓ 25 passed / 0 failedTest plan
superseded/deferred/blocked用法)deferred而非superseded的判斷(spec drift 而非範圍退役)🤖 Generated with Claude Code