修正 agent skills 的 B 方案邊界與 worktree env 規則 - #82
Conversation
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughSkills and documentation updated to retire legacy services from operational contexts. Bounded-service rules and .env provisioning policies now exclude retired services. Per-service testing commands, debug examples, and design documentation aligned to reflect active service implementations and worktree provisioning boundaries. ChangesOperational Skills and Documentation Refresh
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
.claude/skills/apply-and-verify/SKILL.md (1)
71-73: ⚡ Quick winScope the external tests to contract/fake paths explicitly.
Line 72 currently runs
pytest tests -x, which is broader than the “focused tests” intent and can pull in unrelated suites. Prefer targeting only contract/fake directories.Suggested doc fix
-# external platform contracts + test-only fakes -!`cd "<cwd_hint>" && python -m pytest tests -x` +# external platform contracts + test-only fakes +!`cd "<cwd_hint>" && python -m pytest tests/contracts tests/fakes -x`🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.claude/skills/apply-and-verify/SKILL.md around lines 71 - 73, Replace the broad test invocation string `cd "<cwd_hint>" && python -m pytest tests -x` with a scoped pytest call that only runs the contract and fake test folders; locate that exact command in the file and change it so pytest is invoked against the specific directories for contracts and fakes (preserving the `-x` flag and the cwd change), ensuring unrelated test suites are not executed.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.claude/skills/apply-and-verify/SKILL.md:
- Line 138: Fix the typo "呠叫" on the note line referencing `gh pr create` so the
operator instruction is clear; locate the markdown line containing the
backticked `gh pr create` and `<cwd_hint>` and replace "呠叫" with the correct
term (e.g., "呼叫") so the sentence reads that the command can be called from the
main worktree or `<cwd_hint>`.
In `@docs/agent-tooling/opsx-worktree-provision.md`:
- Around line 125-126: Update the manifest sample (env_copied.copied) to match
Step 6 scan targets: either add the missing third service .env entry shown in
Step 6 (so the file lists ".env", "bim-review-coordinator/.env" and the third
active-service path) or clearly label env_copied.copied as a partial example
(e.g., "partial example — not all scan targets listed") so operators know it
doesn't include every active-service entry; reference the manifest file name
env_copied.copied and the Step 6 scan targets when making the change.
---
Nitpick comments:
In @.claude/skills/apply-and-verify/SKILL.md:
- Around line 71-73: Replace the broad test invocation string `cd "<cwd_hint>"
&& python -m pytest tests -x` with a scoped pytest call that only runs the
contract and fake test folders; locate that exact command in the file and change
it so pytest is invoked against the specific directories for contracts and fakes
(preserving the `-x` flag and the cwd change), ensuring unrelated test suites
are not executed.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: acec471f-bf65-48c1-aa9e-55699898b24e
📒 Files selected for processing (5)
.claude/skills/apply-and-verify/SKILL.md.claude/skills/gitnexus-blast-radius/SKILL.md.claude/skills/opsx-worktree-provision/SKILL.md.claude/skills/pr-review-gate/SKILL.mddocs/agent-tooling/opsx-worktree-provision.md
There was a problem hiding this comment.
Pull request overview
This PR updates the tracked agent skills and operator documentation to align with the clarified B-scheme service boundaries and current worktree provisioning rules (including removing retired services from “current runtime” examples).
Changes:
- Update worktree
.envprovisioning rules to scan/copy only current core services (excluding retired_bim-control,_worker,_conversion-service,_s3_storage). - Refresh skill/debug examples to point to the current callback outbox path (
bim-review-coordinator/src/services/callbackOutbox.ts/deliverPending). - Reframe retired services as historical/test-double context in workflow guidance.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/agent-tooling/opsx-worktree-provision.md | Updates env scan/copy targets and documents retired-service exclusion. |
| .claude/skills/pr-review-gate/SKILL.md | Updates debug-loop example to target coordinator callback outbox retry path. |
| .claude/skills/opsx-worktree-provision/SKILL.md | Aligns skill’s env copy behavior with the updated core-service-only rule. |
| .claude/skills/gitnexus-blast-radius/SKILL.md | Updates reviewer-comment→debug-target example to the callback outbox path. |
| .claude/skills/apply-and-verify/SKILL.md | Updates bounded-service boundary description and the focused verification commands. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
變更摘要
bim-review-coordinator作為唯一外部 IFC-ready intake / callback outbox / session control plane，bim-streaming-server作為 internal-only IFC→USDC authority，web-viewer-sample作為 browser client。_worker、_bim-control、_conversion-service、_s3_storage當作 current runtime / startup / smoke dependency 的範例，改成 retired / historical / test-double context。.env，並同步docs/agent-tooling/opsx-worktree-provision.md。bim-review-coordinator/src/services/callbackOutbox.ts/deliverPendingcallback outbox 路徑。驗證
git diff --checkpassed（只有 LF→CRLF warning，沒有 whitespace error）npx gitnexus detect-changes --scope staged --repo AI-BIM-governance→No changes detected.（本次為 docs / agent skills，未命中 indexed runtime symbols）注意
.codex/skills/project-visual-planning已在新 worktree 的 ignored local copy 中同步修正，但依 AGENTS.md policy，.codex/skills/預設不提交，所以未納入此 PR。ghtoken / HTTPS git push auth 無效，因此遠端 branch 與 PR 是透過 GitHub connector 建立。Summary by CodeRabbit