Skip to content

test(design): reapprove canonical A4 baseline #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
monkey1sai merged 2 commits into from
Jul 29, 2026
Merged

test(design): reapprove canonical A4 baseline #429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21241ac
test(design): reapprove canonical A4 baseline
monkey1sai Jul 29, 2026
d455678
Merge remote-tracking branch 'origin/main' into fix/a4-canonical-base…
monkey1sai Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified docs/plans/design-system-baseline/workspace.a4.default/1440x900.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/plans/design-system-baseline/workspace.a4.default/1920x1080.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
12 changes: 9 additions & 3 deletions docs/plans/design-system-reference.manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,14 +422,20 @@
"type": "click_exact_text",
"value": "A4"
},
"baseline_provenance": {
"authority": "canonical_product_surface",
"canonical_route": "#workspace?dock=a4",

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 29, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Register the canonical A4 route in the operative fields

When CI produces A4 evidence, this new canonical_route value is ignored: design-system-visual.spec.ts navigates screen.production_routes[0], which remains the legacy #a4 alias, and the result verifier likewise accepts only production_routes. Consequently the supposedly canonical reapproval still records #a4 as the tested production route and never performs direct navigation to #workspace?dock=a4; update the operative screen mapping, route inventory, and verifier grammar rather than adding an unused provenance-only route.

AGENTS.md reference: AGENTS.md:L43-L44

Useful? React with 👍 / 👎.

"capture_runner": "web-viewer-sample/e2e/design-system-visual.spec.ts",
Comment on lines +426 to +428

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 29, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Restore the A4 golden to the approved design authority

When the A4 visual job runs, design-system-visual.spec.ts renders the production route and compares it with these baseline files, so declaring that same product surface as the baseline authority makes the comparison circular. The newly pinned images capture the raw/table-only production A4 page rather than the approved authoring-origin design, allowing a substantially off-design A4 screen to report a ≤1% diff. Generate the golden through capture-design-system-reference.mjs --rebaseline --confirm-rebaseline against the read-only design origin, or mark the surface reference-missing instead of approving the current implementation.

AGENTS.md reference: AGENTS.md:L39-L39

Useful? React with 👍 / 👎.

"approval": "explicit A4 rebaseline 2026-07-29"
},
"baselines": {
"1440x900": {
"path": "docs/plans/design-system-baseline/workspace.a4.default/1440x900.png",
"sha256": "a67240fdc556419907a98c18ce71c27a30a0f94fe934e99013be82fa11ac81a6"
"sha256": "c8323fcc1860ae28f3ace96aa6f10e013b4ecd728279166471c2349d2224f61d"
},
"1920x1080": {
"path": "docs/plans/design-system-baseline/workspace.a4.default/1920x1080.png",
"sha256": "51f333465e63c19b45df86945af5d25a015d6e3c05f2e6ea569f5cdd40987176"
"sha256": "2dc85cc567e9c707d5720798ba0b80cefe4e2265da8dff3f788928ebf7e3e42c"
}
}
},
Expand Down Expand Up @@ -724,5 +730,5 @@
"docs/plans/ai-bim-geo-viewer-A1.png..A10.png",
"docs/plans/ai-bim-geo-Ai-codeing-A1.png..A10.png"
],
"baseline_snapshot_sha256": "bc767176013f3033cadbf2393add8162984c5333562f75077a6843386de0f698"
"baseline_snapshot_sha256": "4bbc08edced37102d9f93a6e76a958739d5830f32d7e043f89205b46a7cef50e"
}
Loading