Repository navigation
docs(openspec): 歸檔會議生命週期稽核規格 - #34
Merged
monkey1sai merged 1 commit intoMay 12, 2026
Merged
monkey1sai merged 1 commit into
monkey1sai merged 1 commit into
Conversation
Contributor
📝 WalkthroughWalkthroughThis PR formalizes the review session lifecycle event audit specification and documents its completion. The spec now requires coordinator-managed append-only lifecycle event persistence with a stable schema and a new API endpoint, while the roadmap updates track the closure of change ChangesLifecycle Event Audit Definition
Sequence Diagram(s)This section is not applicable to this PR's changes. Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Owner
Author
Code Review SummaryVerdict: No blocking findings Critical
Warnings
Suggestions
Looks Good
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/plans/AI-BIM-governance-saas-roadmap-2026-05.md`:
- Line 40: 移除區塊引用（以 > 開頭的 blockquote）內的多餘空白行，使該 blockquote 內容連續不間斷以修正
MD028（no-blanks-blockquote）錯誤；檢查該文件中所有以 > 開頭的段落（特別是包含說明或列表的
blockquote）並刪除中間的空白行以保持單一連續段落格式（保留原有行首的 > 標記）。
In `@openspec/specs/review-session-request-lifecycle/spec.md`:
- Around line 54-57: 此段落及後續相關要求文字需由英文改為繁體中文，但保留技術字串原文；請將描述「The coordinator SHALL
represent review session lifecycle with `created`, `active`, `closing`,
`closed`, and `failed`...」及後續條款（包含
`_bim-control`、`event_id`、`session_id`、`type`、`sequence`、`created_at`、`payload`、`review_request_id`
等欄位/字樣）翻譯為繁體中文，保留所有 API/欄位/enum/特殊字串原文不變，並更新 Line 54–117 範圍內的
requirement/scenario 文字為繁體中文表述，同時確保語句語意與原英文條件（append-only lifecycle audit
events、persist lifecycle transitions、preserve review_request_id 等）完全對等。
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 9dc1904b-e4af-4099-a7d8-aca9e3208b47
📒 Files selected for processing (8)
docs/plans/AI-BIM-governance-saas-roadmap-2026-05.htmldocs/plans/AI-BIM-governance-saas-roadmap-2026-05.mdopenspec/changes/archive/2026-05-12-coordinator-session-lifecycle-events-audit/.openspec.yamlopenspec/changes/archive/2026-05-12-coordinator-session-lifecycle-events-audit/design.mdopenspec/changes/archive/2026-05-12-coordinator-session-lifecycle-events-audit/proposal.mdopenspec/changes/archive/2026-05-12-coordinator-session-lifecycle-events-audit/specs/review-session-request-lifecycle/spec.mdopenspec/changes/archive/2026-05-12-coordinator-session-lifecycle-events-audit/tasks.mdopenspec/specs/review-session-request-lifecycle/spec.md
| > | ||
| > **2026-05-12 更新（canonical storage batch follow-up）**：新增 active change **`worker-canonical-storage-batch-baseline`**，專門處理已歸檔 #3/#3A 留下的 readiness gap：`C:\Repos\active\iot\AI-BIM-governance\storage\*.ifc` 13-file real batch 尚未 passed，且 `--limit 1` 曾 600s timeout。此 change 是下一個 worker risk burn-down；執行順序明確改為「單檔 real conversion 先跑通 → 用既有 web viewer / Kit 載入 worker-hosted `model.usdc` 看轉檔成果 → 再跑 full 13-file batch」。`coordinator-session-lifecycle-events-audit` 仍保留為下一個新功能候選。 | ||
| > **2026-05-12 更新（canonical storage batch follow-up）**：新增 active change **`worker-canonical-storage-batch-baseline`**，專門處理已歸檔 #3/#3A 留下的 readiness gap：`C:\Repos\active\iot\AI-BIM-governance\storage\*.ifc` 13-file real batch 尚未 passed，且 `--limit 1` 曾 600s timeout。此 change 是下一個 worker risk burn-down；執行順序明確改為「單檔 real conversion 先跑通 → 用既有 web viewer / Kit 載入 worker-hosted `model.usdc` 看轉檔成果 → 再跑 full 13-file batch」。 | ||
|
|
Contributor
There was a problem hiding this comment.
移除 blockquote 內的空白行以避免 MD028。
Line 40 的空白行會觸發 no-blanks-blockquote，建議刪除該空白行。
🧰 Tools
🪛 markdownlint-cli2 (0.22.1)
[warning] 40-40: Blank line inside blockquote
(MD028, no-blanks-blockquote)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/plans/AI-BIM-governance-saas-roadmap-2026-05.md` at line 40, 移除區塊引用（以 >
開頭的 blockquote）內的多餘空白行，使該 blockquote 內容連續不間斷以修正
MD028（no-blanks-blockquote）錯誤；檢查該文件中所有以 > 開頭的段落（特別是包含說明或列表的
blockquote）並刪除中間的空白行以保持單一連續段落格式（保留原有行首的 > 標記）。
Comment on lines
+54
to
57
| The coordinator SHALL represent review session lifecycle with `created`, `active`, `closing`, `closed`, and `failed`. The coordinator SHALL persist lifecycle transitions as append-only lifecycle audit events with stable event schema. `_bim-control` SHALL store review request lifecycle events or request binding updates sufficient to correlate review intent with the coordinator session audit trail. | ||
|
|
||
| Lifecycle audit events MUST include `event_id`, `session_id`, `type`, `sequence`, `created_at`, and `payload`. When a session is created from a review request, lifecycle events MUST preserve `review_request_id` in payload or equivalent correlation data. | ||
|
|
Contributor
There was a problem hiding this comment.
請將新增 OpenSpec 敘述改為繁體中文（保留技術字串原文）。
Line 54 到 Line 117 的 requirement/scenario 文字目前為英文；依規範，OpenSpec artifact 應使用繁體中文（API path、schema 欄位、enum 等可保留原文）。
As per coding guidelines, "All OpenSpec artifacts must use Traditional Chinese (繁體中文); preserve original text for API paths, schema fields, CLI flags, status enums, logs/errors, external product names, and OpenSpec parser required headers."
Also applies to: 62-74, 90-117
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@openspec/specs/review-session-request-lifecycle/spec.md` around lines 54 -
57, 此段落及後續相關要求文字需由英文改為繁體中文，但保留技術字串原文；請將描述「The coordinator SHALL represent review
session lifecycle with `created`, `active`, `closing`, `closed`, and
`failed`...」及後續條款（包含
`_bim-control`、`event_id`、`session_id`、`type`、`sequence`、`created_at`、`payload`、`review_request_id`
等欄位/字樣）翻譯為繁體中文，保留所有 API/欄位/enum/特殊字串原文不變，並更新 Line 54–117 範圍內的
requirement/scenario 文字為繁體中文表述，同時確保語句語意與原英文條件（append-only lifecycle audit
events、persist lifecycle transitions、preserve review_request_id 等）完全對等。
Contributor
There was a problem hiding this comment.
Pull request overview
This PR archives the already-merged OpenSpec change coordinator-session-lifecycle-events-audit and synchronizes the “official” OpenSpec spec plus the May 2026 SaaS roadmap (Markdown + HTML) so that openspec/specs/, openspec/changes/archive/, and planning artifacts stay aligned.
Changes:
- Archived the OpenSpec change into
openspec/changes/archive/2026-05-12-coordinator-session-lifecycle-events-audit/(proposal/design/spec delta/tasks + metadata). - Updated the official
review-session-request-lifecyclespec to include lifecycle audit event requirements and the lifecycle-events endpoint requirements. - Updated the May 2026 SaaS roadmap Markdown/HTML to mark #4 as completed/archived and add validation/evidence references.
Reviewed changes
Copilot reviewed 2 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| openspec/specs/review-session-request-lifecycle/spec.md | Syncs official spec with lifecycle audit log + lifecycle-events endpoint requirements. |
| openspec/changes/archive/2026-05-12-coordinator-session-lifecycle-events-audit/.openspec.yaml | Adds archived change metadata for the 2026-05-12 snapshot. |
| openspec/changes/archive/2026-05-12-coordinator-session-lifecycle-events-audit/proposal.md | Captures the archived change’s rationale and scope boundaries. |
| openspec/changes/archive/2026-05-12-coordinator-session-lifecycle-events-audit/design.md | Captures design decisions and non-goals for the archived change. |
| openspec/changes/archive/2026-05-12-coordinator-session-lifecycle-events-audit/tasks.md | Preserves the completed task checklist and validation steps for the archived change. |
| openspec/changes/archive/2026-05-12-coordinator-session-lifecycle-events-audit/specs/review-session-request-lifecycle/spec.md | Stores the delta spec excerpt for traceability from archive → official spec. |
| docs/plans/AI-BIM-governance-saas-roadmap-2026-05.md | Updates roadmap status/evidence to reflect the archived #4 change. |
| docs/plans/AI-BIM-governance-saas-roadmap-2026-05.html | Regenerates/updates HTML view to match the Markdown roadmap updates. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| - **WHEN** coordinator cannot create the session or open required artifacts | ||
| - **THEN** the review request and session record a failed status with an error reference | ||
| - **AND** any coordinator-side lifecycle audit event for the failure includes `type=failed` or failure details in `payload` |
Comment on lines
+39
to
42
| > **2026-05-12 更新（canonical storage batch follow-up）**：新增 active change **`worker-canonical-storage-batch-baseline`**，專門處理已歸檔 #3/#3A 留下的 readiness gap：`C:\Repos\active\iot\AI-BIM-governance\storage\*.ifc` 13-file real batch 尚未 passed，且 `--limit 1` 曾 600s timeout。此 change 是下一個 worker risk burn-down；執行順序明確改為「單檔 real conversion 先跑通 → 用既有 web viewer / Kit 載入 worker-hosted `model.usdc` 看轉檔成果 → 再跑 full 13-file batch」。 | ||
|
|
||
| > **2026-05-12 更新（並行啟動 #4 lifecycle audit）**：新增 active change **`coordinator-session-lifecycle-events-audit`**，在不干擾 `_worker` canonical batch risk burn-down 的前提下，先把 `bim-review-coordinator` 既有 session events 收斂成 append-only lifecycle audit endpoint 與固定 schema；`_bim-control` 僅補 review request correlation 欄位。此 change 不解凍 Phase 6 audit persistence / observability / webhook production delivery。 | ||
| > **2026-05-12 更新（#4 lifecycle audit archive 對齊）**：依 `openspec/changes/archive/2026-05-12-coordinator-session-lifecycle-events-audit/` 與現行 `openspec/specs/review-session-request-lifecycle/spec.md` 更新 **§1.2 / §1.3 / §1.4 / §2 / §5 / §6 / §10**。#4 已完成並歸檔：`bim-review-coordinator` 已具備 append-only lifecycle audit endpoint 與 `sequence` event schema；`_bim-control` review request lifecycle events 已補 `session_id` / `correlation_id`。此 archive 不解凍 Phase 6 audit persistence / observability / webhook production delivery。 | ||
|
|
monkey1sai
deleted the
codex/openspec/archive-coordinator-session-lifecycle-events-audit
branch
May 12, 2026 11:14
4 of 5 tasks
1 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
變更摘要
歸檔已合併的 OpenSpec change
coordinator-session-lifecycle-events-audit，並同步正式 spec 與 SaaS roadmap Markdown/HTML。修改原因
PR #32 已完成並 squash merge，依 AGENTS.md 的 OpenSpec workflow，正式接受後需要把 delta spec 併入
openspec/specs/，將 change 移入 archive，並更新 roadmap 的 spec 清單、archive 溯源、Phase 狀態與下一步規劃。主要變更
openspec/changes/coordinator-session-lifecycle-events-audit/移至openspec/changes/archive/2026-05-12-coordinator-session-lifecycle-events-audit/。openspec/specs/review-session-request-lifecycle/spec.md，納入 lifecycle audit endpoint、sequenceevent schema、lifecycle-only filter 與 close/release audit requirements。docs/plans/AI-BIM-governance-saas-roadmap-2026-05.md，把 fix(coordinator): timeout BimControlClient fetches to stop test flakiness #4 從 active 改為 completed / archived，並補 archive 溯源與驗證紀錄。docs/plans/AI-BIM-governance-saas-roadmap-2026-05.html，保持同名 HTML 檢視版與 Markdown source 對齊。驗證方式
openspec validate --all --strict：12 passed, 0 failedopenspec list：active change 只剩worker-canonical-storage-batch-baselinegitnexus detect-changes --scope all --repo C:\Users\IOT\.codex\worktrees\8dc5\AI-BIM-governance：risk low, affected processes 0git diff --check：通過，僅有 Windows CRLF 提示風險與影響
review-session-request-lifecycle正式 spec 會成為後續 fix(scripts): 修正 stop-all 無法清除殘留服務 #6 webhook / observability 探索的 schema 依據。回滾方式
若需撤回，revert 本 PR 的 squash commit；這會把 archived change 移回 active change 目錄，並還原正式 spec / roadmap 的 archive sync。
後續建議
worker-canonical-storage-batch-baseline。Summary by CodeRabbit
New Features
Documentation