chore(env): 明確標註 conversion API env ownership - #327
Conversation
|
Warning Review limit reached
Next review available in: 14 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe environment examples now document retired legacy keys, identify ChangesEnvironment variable guidance
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@bim-review-coordinator/.env.example`:
- Line 6: Move the CONVERSION_API_BASE placeholder before the HOST entry in the
environment example, preserving its existing value and keeping the file
compliant with dotenv-linter key ordering.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 15784e82-c3b1-44bc-a802-7e79f4047abd
📒 Files selected for processing (2)
.env.examplebim-review-coordinator/.env.example
記錄 root 與 coordinator 的 key ownership、legacy precedence、空值 placeholder、安全邊界與驗證門檻。 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
記錄 PR #327 的 local preflight、CI/reviewer、squash merge 與 worktree closeout gates。 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
摘要
.env.example明確標註 conversion/storage env key 的 ownership 與退役邊界。bim-review-coordinator/.env.example登記空值 legacy aliasCONVERSION_API_BASE;既有STREAMING_CONVERSION_API_BASEprecedence 不變。.env、runtime code、public API 或預設啟用狀態。驗證
npm test -- tests/config.test.ts tests/env-example-minio-watch-parity.test.ts:28 tests passed。pwsh -NoProfile -NonInteractive -File .\scripts\tests\test-preflight-env.ps1:ALL PASSED。npm run verify(bim-review-coordinator):build passed,56 test files / 611 tests passed。git diff --check:passed。detect_changes(compare main):2 files、0 symbols、risk low。Deploy Path Verification
.env.examplekey ownership/documentation only;不改 runtime default 或 production.envscripts/deploy.ps1無需修改,已用 DryRun 驗證.\scripts\deploy.ps1 -DryRunpassed;Phase 2 skipped,未執行任何 auto-fixnpm run verify(611 tests)+scripts/tests/test-preflight-env.ps1passed已知風險
npm ci回報既有 dependency audit:8 moderate、3 high、1 critical;本 PR 不擴大到 dependency upgrade。.env/venv/build 尚未建立及既有 runtime ports 被外部程序占用;不影響本次 read-only DryRun,且未停止任何程序。Summary by CodeRabbit
Formal spec 與執行計畫
docs/superpowers/specs/2026-07-13-conversion-api-env-ownership-design.mddocs/superpowers/plans/2026-07-13-conversion-api-env-ownership-closeout.mddocs/superpowers/specs/*.md是 local review agent 接受的 formal spec evidence。